mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 05:37:34 +00:00
LibWeb: Compute text-decoration-color
values
Previosly, we used only the text color as a line decoration color. The FIXME comment has been directly copy-pasted from the border color note a few lines below.
This commit is contained in:
parent
e74b0b14ed
commit
f9d66bef5d
3 changed files with 12 additions and 2 deletions
|
@ -426,6 +426,11 @@ void NodeWithStyle::apply_style(const CSS::StyleProperties& specified_style)
|
|||
|
||||
computed_values.set_color(specified_style.color_or_fallback(CSS::PropertyID::Color, *this, CSS::InitialValues::color()));
|
||||
|
||||
// FIXME: The default text decoration color value is `currentcolor`, but since we can't resolve that easily,
|
||||
// we just manually grab the value from `color`. This makes it dependent on `color` being
|
||||
// specified first, so it's far from ideal.
|
||||
computed_values.set_text_decoration_color(specified_style.color_or_fallback(CSS::PropertyID::TextDecorationColor, *this, computed_values.color()));
|
||||
|
||||
computed_values.set_z_index(specified_style.z_index());
|
||||
computed_values.set_opacity(specified_style.opacity());
|
||||
if (computed_values.opacity() == 0)
|
||||
|
|
|
@ -68,17 +68,19 @@ void TextNode::paint_text_decoration(Gfx::Painter& painter, LineBoxFragment cons
|
|||
return;
|
||||
}
|
||||
|
||||
auto line_color = computed_values().text_decoration_color();
|
||||
|
||||
switch (computed_values().text_decoration_style()) {
|
||||
// FIXME: Implement the other styles
|
||||
case CSS::TextDecorationStyle::Solid:
|
||||
case CSS::TextDecorationStyle::Double:
|
||||
case CSS::TextDecorationStyle::Dashed:
|
||||
case CSS::TextDecorationStyle::Dotted:
|
||||
painter.draw_line(line_start_point, line_end_point, computed_values().color());
|
||||
painter.draw_line(line_start_point, line_end_point, line_color);
|
||||
break;
|
||||
case CSS::TextDecorationStyle::Wavy:
|
||||
// FIXME: There is a thing called text-decoration-thickness which also affects the amplitude here.
|
||||
painter.draw_triangle_wave(line_start_point, line_end_point, computed_values().color(), 2);
|
||||
painter.draw_triangle_wave(line_start_point, line_end_point, line_color, 2);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue