RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:47:35 +00:00
Code Issues Activity Actions

LibVideo: Allocate Vector2D underlying storage with new, not malloc

Browse source 
Using malloc does not invoke T's constructor, nor were were invoking T's
constructor ourselves. Accessing T without invoking its constructor is
undefined behavior.
This commit is contained in:
Timothy Flynn 2023-04-24 12:47:15 -04:00 • committed by Andrew Kaster
parent bb045b3c70
commit f9d8e42636
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibVideo/VP9/ContextStorage.h
View file

@ -112,7 +112,7 @@ public:
clear_storage(); clear_storage();
size_t size = height * width; size_t size = height * width;
auto* new_storage = static_cast<T*>(malloc(size * sizeof(T))); auto* new_storage = new (nothrow) T[size];
if (!new_storage) if (!new_storage)
return Error::from_errno(ENOMEM); return Error::from_errno(ENOMEM);
m_storage = new_storage; m_storage = new_storage;
@ -194,8 +194,7 @@ public:
private: private:
void clear_storage() void clear_storage()
{ {
if (m_storage) delete[] m_storage;
free(m_storage);
m_storage = nullptr; m_storage = nullptr;
m_width = 0; m_width = 0;
m_height = 0; m_height = 0;