mirror of
https://github.com/RGBCube/serenity
synced 2025-07-24 21:47:43 +00:00
Kernel: Actually, let's not hang() on bad incoming packets
That kinda defeats the purpose of being smart enough to ignore them :^)
This commit is contained in:
parent
9e2a00248e
commit
f9de264f88
1 changed files with 0 additions and 3 deletions
|
@ -185,21 +185,18 @@ void handle_ipv4(const EthernetFrameHeader& eth, int frame_size)
|
||||||
constexpr int minimum_ipv4_frame_size = sizeof(EthernetFrameHeader) + sizeof(IPv4Packet);
|
constexpr int minimum_ipv4_frame_size = sizeof(EthernetFrameHeader) + sizeof(IPv4Packet);
|
||||||
if (frame_size < minimum_ipv4_frame_size) {
|
if (frame_size < minimum_ipv4_frame_size) {
|
||||||
kprintf("handle_ipv4: Frame too small (%d, need %d)\n", frame_size, minimum_ipv4_frame_size);
|
kprintf("handle_ipv4: Frame too small (%d, need %d)\n", frame_size, minimum_ipv4_frame_size);
|
||||||
hang();
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
auto& packet = *static_cast<const IPv4Packet*>(eth.payload());
|
auto& packet = *static_cast<const IPv4Packet*>(eth.payload());
|
||||||
|
|
||||||
if (packet.length() < sizeof(IPv4Packet)) {
|
if (packet.length() < sizeof(IPv4Packet)) {
|
||||||
kprintf("handle_ipv4: IPv4 packet too short (%u, need %u)\n", packet.length(), sizeof(IPv4Packet));
|
kprintf("handle_ipv4: IPv4 packet too short (%u, need %u)\n", packet.length(), sizeof(IPv4Packet));
|
||||||
hang();
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
size_t actual_ipv4_packet_length = frame_size - sizeof(EthernetFrameHeader);
|
size_t actual_ipv4_packet_length = frame_size - sizeof(EthernetFrameHeader);
|
||||||
if (packet.length() > actual_ipv4_packet_length) {
|
if (packet.length() > actual_ipv4_packet_length) {
|
||||||
kprintf("handle_ipv4: IPv4 packet claims to be longer than it is (%u, actually %zu)\n", packet.length(), actual_ipv4_packet_length);
|
kprintf("handle_ipv4: IPv4 packet claims to be longer than it is (%u, actually %zu)\n", packet.length(), actual_ipv4_packet_length);
|
||||||
hang();
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue