RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:37:47 +00:00
Code Issues Activity Actions

LibWeb: Make LiveNodeList faster when it only cares about children

Browse source 
Same optimization as HTMLCollection, ported to LiveNodeList.
This commit is contained in:
Andreas Kling 2023-05-23 12:28:16 +02:00
parent fe92b54137
commit fa25f70086
3 changed files with 27 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/DOM/LiveNodeList.h
View file

@ -18,7 +18,12 @@ class LiveNodeList final : public NodeList {
WEB_PLATFORM_OBJECT(LiveNodeList, NodeList);
public:
static WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeList>> create(JS::Realm&, Node& root, Function<bool(Node const&)> filter);
enum class Scope {
Children,
Descendants,
};
static WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeList>> create(JS::Realm&, Node& root, Scope, Function<bool(Node const&)> filter);
virtual ~LiveNodeList() override;
virtual u32 length() const override;
@ -27,7 +32,7 @@ public:
virtual bool is_supported_property_index(u32) const override;
private:
LiveNodeList(JS::Realm&, Node& root, Function<bool(Node const&)> filter);
LiveNodeList(JS::Realm&, Node& root, Scope, Function<bool(Node const&)> filter);
virtual void visit_edges(Cell::Visitor&) override;
@ -35,6 +40,7 @@ private:
JS::NonnullGCPtr<Node> m_root;
Function<bool(Node const&)> m_filter;
Scope m_scope { Scope::Descendants };
};
}