RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:27:43 +00:00
Code Issues Activity Actions

Kernel+UserspaceEmulator: Remove unused sys$gettimeofday()

Browse source 
Now that LibC uses clock_gettime() to implement gettimeofday(), we can
get rid of this entire syscall. :^)
This commit is contained in:
Andreas Kling 2021-08-10 12:50:42 +02:00
parent 5f6e0e0162
commit fa64ab26a4
5 changed files with 0 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Kernel/API/Syscall.h
View file

@ -64,7 +64,6 @@ enum class NeedsBigProcessLock {
S(munmap, NeedsBigProcessLock::Yes) \ S(munmap, NeedsBigProcessLock::Yes) \
S(get_dir_entries, NeedsBigProcessLock::Yes) \ S(get_dir_entries, NeedsBigProcessLock::Yes) \
S(getcwd, NeedsBigProcessLock::Yes) \ S(getcwd, NeedsBigProcessLock::Yes) \
S(gettimeofday, NeedsBigProcessLock::No) \
S(gethostname, NeedsBigProcessLock::No) \ S(gethostname, NeedsBigProcessLock::No) \
S(sethostname, NeedsBigProcessLock::No) \ S(sethostname, NeedsBigProcessLock::No) \
S(chdir, NeedsBigProcessLock::Yes) \ S(chdir, NeedsBigProcessLock::Yes) \

1
Kernel/Process.h
View file

@ -317,7 +317,6 @@ public:
KResultOr<FlatPtr> sys$chdir(Userspace<const char*>, size_t); KResultOr<FlatPtr> sys$chdir(Userspace<const char*>, size_t);
KResultOr<FlatPtr> sys$fchdir(int fd); KResultOr<FlatPtr> sys$fchdir(int fd);
KResultOr<FlatPtr> sys$adjtime(Userspace<const timeval*>, Userspace<timeval*>); KResultOr<FlatPtr> sys$adjtime(Userspace<const timeval*>, Userspace<timeval*>);
KResultOr<FlatPtr> sys$gettimeofday(Userspace<timeval*>);
KResultOr<FlatPtr> sys$clock_gettime(clockid_t, Userspace<timespec*>); KResultOr<FlatPtr> sys$clock_gettime(clockid_t, Userspace<timespec*>);
KResultOr<FlatPtr> sys$clock_settime(clockid_t, Userspace<const timespec*>); KResultOr<FlatPtr> sys$clock_settime(clockid_t, Userspace<const timespec*>);
KResultOr<FlatPtr> sys$clock_nanosleep(Userspace<const Syscall::SC_clock_nanosleep_params*>); KResultOr<FlatPtr> sys$clock_nanosleep(Userspace<const Syscall::SC_clock_nanosleep_params*>);

10
Kernel/Syscalls/clock.cpp
View file

@ -116,14 +116,4 @@ KResultOr<FlatPtr> Process::sys$adjtime(Userspace<const timeval*> user_delta, Us
return 0; return 0;
} }
KResultOr<FlatPtr> Process::sys$gettimeofday(Userspace<timeval*> user_tv)
{
VERIFY_NO_PROCESS_BIG_LOCK(this);
REQUIRE_PROMISE(stdio);
auto tv = kgettimeofday().to_timeval();
if (!copy_to_user(user_tv, &tv))
return EFAULT;
return 0;
}
} }

1
Userland/DevTools/UserspaceEmulator/Emulator.h
View file

@ -170,7 +170,6 @@ private:
int virt$get_process_name(FlatPtr buffer, int size); int virt$get_process_name(FlatPtr buffer, int size);
int virt$set_process_name(FlatPtr buffer, int size); int virt$set_process_name(FlatPtr buffer, int size);
int virt$set_mmap_name(FlatPtr); int virt$set_mmap_name(FlatPtr);
int virt$gettimeofday(FlatPtr);
int virt$clock_gettime(int, FlatPtr); int virt$clock_gettime(int, FlatPtr);
int virt$clock_nanosleep(FlatPtr); int virt$clock_nanosleep(FlatPtr);
int virt$dbgputstr(FlatPtr characters, int length); int virt$dbgputstr(FlatPtr characters, int length);

12
Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp
View file

@ -203,8 +203,6 @@ u32 Emulator::virt_syscall(u32 function, u32 arg1, u32 arg2, u32 arg3)
case SC_exit: case SC_exit:
virt$exit((int)arg1); virt$exit((int)arg1);
return 0; return 0;
case SC_gettimeofday:
return virt$gettimeofday(arg1);
case SC_clock_gettime: case SC_clock_gettime:
return virt$clock_gettime(arg1, arg2); return virt$clock_gettime(arg1, arg2);
case SC_clock_settime: case SC_clock_settime:
@ -507,16 +505,6 @@ int Emulator::virt$killpg(int pgrp, int sig)
return syscall(SC_killpg, pgrp, sig); return syscall(SC_killpg, pgrp, sig);
} }
int Emulator::virt$gettimeofday(FlatPtr timeval)
{
struct timeval host_timeval;
int rc = syscall(SC_gettimeofday, &host_timeval);
if (rc < 0)
return rc;
mmu().copy_to_vm(timeval, &host_timeval, sizeof(host_timeval));
return rc;
}
int Emulator::virt$clock_gettime(int clockid, FlatPtr timespec) int Emulator::virt$clock_gettime(int clockid, FlatPtr timespec)
{ {
struct timespec host_timespec; struct timespec host_timespec;