From faa2c74b49e19723c9da52dab051a66b0cebfb17 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sat, 14 Aug 2021 18:50:10 -0400 Subject: [PATCH] LibGUI: Simplify AboutDialog::version_string() No behavior change. --- Userland/Libraries/LibGUI/AboutDialog.cpp | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/Userland/Libraries/LibGUI/AboutDialog.cpp b/Userland/Libraries/LibGUI/AboutDialog.cpp index e85a2a1610..09d01d45b0 100644 --- a/Userland/Libraries/LibGUI/AboutDialog.cpp +++ b/Userland/Libraries/LibGUI/AboutDialog.cpp @@ -95,19 +95,11 @@ String AboutDialog::version_string() const auto version_config = Core::ConfigFile::open("/res/version.ini"); auto major_version = version_config->read_entry("Version", "Major", "0"); auto minor_version = version_config->read_entry("Version", "Minor", "0"); - auto git_version = version_config->read_entry("Version", "Git", ""); StringBuilder builder; - builder.append("Version "); - builder.append(major_version); - builder.append('.'); - builder.append(minor_version); - - if (git_version != "") { - builder.append(".g"); - builder.append(git_version); - } - + builder.appendff("Version {}.{}", major_version, minor_version); + if (auto git_version = version_config->read_entry("Version", "Git", ""); git_version != "") + builder.appendff(".g{}", git_version); return builder.to_string(); }