From fac0a456e6b40e0b9e91d8b2afda6d1a4b107802 Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis@chromium.org>
Date: Mon, 20 Nov 2023 21:49:44 -0500
Subject: [PATCH] MacPDF: Use correct encoding for outline titles

The title of an OutlineItem is already in UTF-8.

This is currently done in LibPDF's Parser::parse_string(). I think
that's not quite the right place (it shouldn't be done for all strings)
and not done quite right (text strings should convert from
PDFDocEncoding to UTF-8 unless prefixed by an UTF-8 BOM), but even if
that changes, I think we'll keep OutlineItem.title in UTF-8.
---
 Meta/Lagom/Contrib/MacPDF/MacPDFOutlineViewDataSource.mm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Meta/Lagom/Contrib/MacPDF/MacPDFOutlineViewDataSource.mm b/Meta/Lagom/Contrib/MacPDF/MacPDFOutlineViewDataSource.mm
index c2623c4ca0..fde1fa17f1 100644
--- a/Meta/Lagom/Contrib/MacPDF/MacPDFOutlineViewDataSource.mm
+++ b/Meta/Lagom/Contrib/MacPDF/MacPDFOutlineViewDataSource.mm
@@ -60,7 +60,7 @@
 {
     if (_groupName)
         return _groupName;
-    return [NSString stringWithFormat:@"%s", _item->title.characters()]; // FIXME: encoding?
+    return [NSString stringWithUTF8String:_item->title.characters()];
 }
 @end