RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:07:35 +00:00
Code Issues Activity Actions

LibJS: Use Stream::format instead of manually formating and printing

Browse source
This commit is contained in:
Peter Brottveit Bock 2023-04-22 22:40:10 +02:00 • committed by Andreas Kling
parent 6f6d6c654d
commit fac7045a44
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Print.cpp
View file

@ -140,15 +140,10 @@ DeprecatedString strip_ansi(StringView format_string)
template<typename... Args> template<typename... Args>
ErrorOr<void> js_out(JS::PrintContext& print_context, CheckedFormatString<Args...> format_string, Args const&... args) ErrorOr<void> js_out(JS::PrintContext& print_context, CheckedFormatString<Args...> format_string, Args const&... args)
{ {
DeprecatedString formatted;
if (print_context.strip_ansi) if (print_context.strip_ansi)
formatted = DeprecatedString::formatted(strip_ansi(format_string.view()), args...); TRY(print_context.stream.format(strip_ansi(format_string.view()), args...));
else else
formatted = DeprecatedString::formatted(format_string.view(), args...); TRY(print_context.stream.format(format_string.view(), args...));
auto bytes = formatted.bytes();
while (!bytes.is_empty())
bytes = bytes.slice(TRY(print_context.stream.write_some(bytes)));
return {}; return {};
} }