From fad825e94e831d5b215420d3f53fc46f84e981a6 Mon Sep 17 00:00:00 2001 From: Tobias Christiansen Date: Tue, 14 Sep 2021 22:37:58 +0200 Subject: [PATCH] LibWeb: Flexbox: Avoid division by zero This is not a good thing, one should not divide by zero! :^) --- Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp b/Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp index 52ec8af999..fa756ca6fc 100644 --- a/Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp +++ b/Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp @@ -504,7 +504,9 @@ void FlexFormattingContext::run(Box& box, LayoutMode) }); for_each_unfrozen_item([&](FlexItem* flex_item) { - float ratio = flex_item->scaled_flex_shrink_factor / sum_of_scaled_flex_shrink_factor_of_unfrozen_items; + float ratio = 1.0f; + if (sum_of_scaled_flex_shrink_factor_of_unfrozen_items != 0.0f) + ratio = flex_item->scaled_flex_shrink_factor / sum_of_scaled_flex_shrink_factor_of_unfrozen_items; flex_item->target_main_size = flex_item->flex_base_size - (AK::abs(remaining_free_space) * ratio); }); }