RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibJS: Allow exporting any imported bindings

Browse source
This commit is contained in:
davidot 2022-09-01 23:13:45 +02:00 • committed by Linus Groh
parent 462c6df24b
commit faf1430ce4
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Parser.cpp
View file

@ -565,8 +565,15 @@ void Parser::parse_module(Program& program)
if (name == exported_name) if (name == exported_name)
found = true; found = true;
}); });
for (auto& import : program.imports()) {
if (import.has_bound_name(exported_name)) {
found = true;
break;
}
}
if (!found) if (!found)
syntax_error(String::formatted("'{}' is not declared", exported_name)); syntax_error(String::formatted("'{}' in export is not declared", exported_name), export_statement.source_range().start);
} }
} }
} }

4
Userland/Libraries/LibJS/Tests/modules/basic-modules.js
View file

@ -190,6 +190,10 @@ describe("in- and exports", () => {
test("can have multiple star imports even from the same file", () => { test("can have multiple star imports even from the same file", () => {
expectModulePassed("./multiple-star-imports.mjs"); expectModulePassed("./multiple-star-imports.mjs");
}); });
test("can export namespace via binding", () => {
expectModulePassed("./re-export-namespace-via-binding.mjs");
});
}); });
describe("loops", () => { describe("loops", () => {

7
Userland/Libraries/LibJS/Tests/modules/re-export-namespace-via-binding.mjs Normal file
View file

@ -0,0 +1,7 @@
import * as namespace from "./default-and-star-export.mjs";
import { "*" as fromStar } from "./default-and-star-export.mjs";
export { namespace };
import { namespace as nm } from "./re-export-namespace-via-binding.mjs";
export const passed = nm === namespace && fromStar === namespace["*"];