RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:17:34 +00:00
Code Issues Activity Actions

LibWeb: Replace incorrect uses of AK::is_ascii_space()

Browse source
This commit is contained in:
Linus Groh 2022-10-01 18:14:32 +01:00 • committed by Andreas Kling
parent 87ac38c78b
commit fb21271334
4 changed files with 10 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/HTML/Parser/HTMLEncodingDetection.cpp
View file

@ -12,6 +12,7 @@
#include <LibWeb/DOM/Attr.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/HTML/Parser/HTMLEncodingDetection.h>
#include <LibWeb/Infra/CharacterTypes.h>
#include <ctype.h>
namespace Web::HTML {
@ -50,8 +51,7 @@ Optional<StringView> extract_character_encoding_from_meta_element(String const&
lexer.ignore(charset_index.value() + 7);
lexer.ignore_while([](char c) {
// FIXME: Not the exact same ASCII whitespace. The spec does not include vertical tab (\v).
return is_ascii_space(c);
return Infra::is_ascii_whitespace(c);
});
if (lexer.peek() != '=')
@ -64,8 +64,7 @@ Optional<StringView> extract_character_encoding_from_meta_element(String const&
lexer.ignore();
lexer.ignore_while([](char c) {
// FIXME: Not the exact same ASCII whitespace. The spec does not include vertical tab (\v).
return is_ascii_space(c);
return Infra::is_ascii_whitespace(c);
});
if (lexer.is_eof())
@ -90,8 +89,7 @@ Optional<StringView> extract_character_encoding_from_meta_element(String const&
}
auto encoding = lexer.consume_until([](char c) {
// FIXME: Not the exact same ASCII whitespace. The spec does not include vertical tab (\v).
return is_ascii_space(c) || c == ';';
return Infra::is_ascii_whitespace(c) || c == ';';
});
return TextCodec::get_standardized_encoding(encoding);
}

3
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -28,6 +28,7 @@
#include <LibWeb/HTML/Parser/HTMLParser.h>
#include <LibWeb/HTML/Parser/HTMLToken.h>
#include <LibWeb/HTML/Window.h>
#include <LibWeb/Infra/CharacterTypes.h>
#include <LibWeb/Namespace.h>
#include <LibWeb/SVG/TagNames.h>
@ -3668,7 +3669,7 @@ RefPtr<CSS::StyleValue> parse_dimension_value(StringView string)
auto position = input.begin();
// 3. Skip ASCII whitespace within input given position.
while (position != input.end() && is_ascii_space(*position))
while (position != input.end() && Infra::is_ascii_whitespace(*position))
++position;
// 4. If position is past the end of input or the code point at position within input is not an ASCII digit,