RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-26 01:25:08 +00:00
Code Issues Activity Actions

Kernel: Allow sending SIGCONT to processes in the same group

Browse source 
Allow sending `SIGCONT` to processes that share the same `pgid`.
This is allowed in Linux aswell.

Also fixes a FIXME :^)
This commit is contained in:
yyny 2022-12-19 21:27:58 +01:00 • committed by Andreas Kling
parent 9ca979846c
commit fb2be937ac
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Syscalls/kill.cpp
View file

@ -11,11 +11,15 @@ namespace Kernel {
ErrorOr<void> Process::do_kill(Process& process, int signal) ErrorOr<void> Process::do_kill(Process& process, int signal)
{ {
// FIXME: Allow sending SIGCONT to everyone in the process group.
// FIXME: Should setuid processes have some special treatment here? // FIXME: Should setuid processes have some special treatment here?
auto credentials = this->credentials(); auto credentials = this->credentials();
auto kill_process_credentials = process.credentials(); auto kill_process_credentials = process.credentials();
if (!credentials->is_superuser() && credentials->euid() != kill_process_credentials->uid() && credentials->uid() != kill_process_credentials->uid())
bool can_send_signal = credentials->is_superuser()
|| credentials->euid() == kill_process_credentials->uid()
|| credentials->uid() == kill_process_credentials->uid()
|| (signal == SIGCONT && credentials->pgid() == kill_process_credentials->pgid());
if (!can_send_signal)
return EPERM; return EPERM;
if (process.is_kernel_process()) { if (process.is_kernel_process()) {
dbgln("Attempted to send signal {} to kernel process {} ({})", signal, process.name(), process.pid()); dbgln("Attempted to send signal {} to kernel process {} ({})", signal, process.name(), process.pid());