RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 21:07:35 +00:00
Code Issues Activity Actions

LibWeb: Align GridFormattingContext::run_track_sizing() with the spec

Browse source 
1. Stop using -1 to indicate infinity value of growth limit. Just use
   INFINITY for that.
2. More complete implementation of "Expand Flexible Tracks" step.
3. Return AvailableSize from get_free_space: spec says that this
   function can return indefinite size and it is ok.
This commit is contained in:
Aliaksandr Kalenik 2023-05-09 05:03:14 +03:00 • committed by Andreas Kling
parent f2323b5b99
commit fb6b52b3fb
12 changed files with 164 additions and 161 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Tests/LibWeb/Layout/expected/grid/row-height.txt
View file

@ -4,30 +4,30 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <div.grid-container> at (8,8) content-size 784x67.46875 [GFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 0x0 [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (8,8) content-size 392.140625x50 [BFC] children: inline
BlockContainer <div.grid-item> at (8,8) content-size 392x50 [BFC] children: inline
line 0 width: 6.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,8 6.34375x17.46875]
"1"
TextNode <#text>
BlockContainer <(anonymous)> at (8,8) content-size 0x0 [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (400.140625,8) content-size 392x50 [BFC] children: inline
BlockContainer <div.grid-item> at (400,8) content-size 392x50 [BFC] children: inline
line 0 width: 8.8125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [400.140625,8 8.8125x17.46875]
frag 0 from TextNode start: 0, length: 1, rect: [400,8 8.8125x17.46875]
"2"
TextNode <#text>
BlockContainer <(anonymous)> at (8,8) content-size 0x0 [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (8,58) content-size 392.140625x17.46875 [BFC] children: inline
BlockContainer <div.grid-item> at (8,58) content-size 392x17.46875 [BFC] children: inline
line 0 width: 9.09375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,58 9.09375x17.46875]
"3"
TextNode <#text>
BlockContainer <(anonymous)> at (8,8) content-size 0x0 [BFC] children: inline
TextNode <#text>
BlockContainer <div.grid-item> at (400.140625,58) content-size 392x17.46875 [BFC] children: inline
BlockContainer <div.grid-item> at (400,58) content-size 392x17.46875 [BFC] children: inline
line 0 width: 7.75, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [400.140625,58 7.75x17.46875]
frag 0 from TextNode start: 0, length: 1, rect: [400,58 7.75x17.46875]
"4"
TextNode <#text>
BlockContainer <(anonymous)> at (8,8) content-size 0x0 [BFC] children: inline