RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:07:35 +00:00
Code Issues Activity Actions

LibWeb: Add support for the input size attribute

Browse source
This commit is contained in:
Bastiaan van der Plaat 2023-11-24 17:37:53 +01:00 • committed by Andreas Kling
parent d9fb116bcc
commit fb7b03d162
5 changed files with 30 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -18,6 +18,7 @@
#include <LibWeb/HTML/HTMLDivElement.h>
#include <LibWeb/HTML/HTMLFormElement.h>
#include <LibWeb/HTML/HTMLInputElement.h>
#include <LibWeb/HTML/Numbers.h>
#include <LibWeb/HTML/Scripting/Environments.h>
#include <LibWeb/HTML/Window.h>
#include <LibWeb/Infra/CharacterTypes.h>
@ -1158,6 +1159,24 @@ i32 HTMLInputElement::default_tab_index_value() const
return 0;
}
// https://html.spec.whatwg.org/multipage/input.html#the-size-attribute
unsigned HTMLInputElement::size() const
{
// The size IDL attribute is limited to only positive numbers and has a default value of 20.
auto maybe_size_string = get_attribute(HTML::AttributeNames::size);
if (maybe_size_string.has_value()) {
auto maybe_size = parse_non_negative_integer(maybe_size_string.value());
if (maybe_size.has_value())
return maybe_size.value();
}
return 20;
}
WebIDL::ExceptionOr<void> HTMLInputElement::set_size(unsigned value)
{
return set_attribute(HTML::AttributeNames::size, MUST(String::number(value)));
}
// https://html.spec.whatwg.org/multipage/input.html#dom-input-valueasnumber
WebIDL::ExceptionOr<double> HTMLInputElement::value_as_number() const
{

3
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -97,6 +97,9 @@ public:
// https://html.spec.whatwg.org/multipage/input.html#update-the-file-selection
void update_the_file_selection(JS::NonnullGCPtr<FileAPI::FileList>);
unsigned size() const;
WebIDL::ExceptionOr<void> set_size(unsigned value);
WebIDL::ExceptionOr<double> value_as_number() const;
WebIDL::ExceptionOr<void> set_value_as_number(double value);

2
Userland/Libraries/LibWeb/HTML/HTMLInputElement.idl
View file

@ -34,7 +34,7 @@ interface HTMLInputElement : HTMLElement {
[CEReactions, Reflect] attribute DOMString placeholder;
[CEReactions, Reflect=readonly] attribute boolean readOnly;
[CEReactions, Reflect] attribute boolean required;
// FIXME: [CEReactions] attribute unsigned long size;
[CEReactions] attribute unsigned long size;
[CEReactions, Reflect] attribute DOMString src;
[CEReactions, Reflect] attribute DOMString step;
[CEReactions] attribute DOMString type;