RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

WindowServer+LibGUI: Make menu and menubar teardown asynchronous

Browse source 
Clients don't need to wait for WindowServer to tear down a menu or
menubar before continuing.
This commit is contained in:
Andreas Kling 2021-05-10 11:52:30 +02:00
parent b1fe5d5517
commit fb93535419
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/Menu.cpp
View file

@ -123,7 +123,7 @@ void Menu::unrealize_menu()
if (m_menu_id == -1) if (m_menu_id == -1)
return; return;
all_menus().remove(m_menu_id); all_menus().remove(m_menu_id);
WindowServerConnection::the().destroy_menu(m_menu_id); WindowServerConnection::the().async_destroy_menu(m_menu_id);
m_menu_id = -1; m_menu_id = -1;
} }

2
Userland/Libraries/LibGUI/Menubar.cpp
View file

@ -37,7 +37,7 @@ void Menubar::unrealize_menubar()
{ {
if (m_menubar_id == -1) if (m_menubar_id == -1)
return; return;
WindowServerConnection::the().destroy_menubar(m_menubar_id); WindowServerConnection::the().async_destroy_menubar(m_menubar_id);
m_menubar_id = -1; m_menubar_id = -1;
} }

4
Userland/Services/WindowServer/WindowServer.ipc
View file

@ -3,10 +3,10 @@ endpoint WindowServer
greet() => (Gfx::IntRect screen_rect, Core::AnonymousBuffer theme_buffer) greet() => (Gfx::IntRect screen_rect, Core::AnonymousBuffer theme_buffer)
create_menubar() => (i32 menubar_id) create_menubar() => (i32 menubar_id)
destroy_menubar(i32 menubar_id) => () destroy_menubar(i32 menubar_id) =|
create_menu([UTF8] String menu_title) => (i32 menu_id) create_menu([UTF8] String menu_title) => (i32 menu_id)
destroy_menu(i32 menu_id) => () destroy_menu(i32 menu_id) =|
add_menu_to_menubar(i32 menubar_id, i32 menu_id) =| add_menu_to_menubar(i32 menubar_id, i32 menu_id) =|