RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-16 20:32:09 +00:00
Code Issues Activity Actions

LibJS: Add missing exception checks to Number() constructor

Browse source
This commit is contained in:
Linus Groh 2021-06-19 02:03:37 +01:00
parent 8e26c7a1dd
commit fba3c77a04
1 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibJS/Runtime/NumberConstructor.cpp
View file

@ -84,15 +84,26 @@ static Value get_value_from_constructor_argument(GlobalObject& global_object)
// 21.1.1.1 Number ( value ), https://tc39.es/ecma262/#sec-number-constructor-number-value // 21.1.1.1 Number ( value ), https://tc39.es/ecma262/#sec-number-constructor-number-value
Value NumberConstructor::call() Value NumberConstructor::call()
{ {
return get_value_from_constructor_argument(global_object()); auto& vm = this->vm();
auto& global_object = this->global_object();
auto number = get_value_from_constructor_argument(global_object);
if (vm.exception())
return {};
return number;
} }
// 21.1.1.1 Number ( value ), https://tc39.es/ecma262/#sec-number-constructor-number-value // 21.1.1.1 Number ( value ), https://tc39.es/ecma262/#sec-number-constructor-number-value
Value NumberConstructor::construct(Function&) Value NumberConstructor::construct(Function&)
{ {
auto number = get_value_from_constructor_argument(global_object()); auto& vm = this->vm();
auto& global_object = this->global_object();
auto number = get_value_from_constructor_argument(global_object);
if (vm.exception())
return {};
// FIXME: Use OrdinaryCreateFromConstructor(NewTarget, "%Number.prototype%") // FIXME: Use OrdinaryCreateFromConstructor(NewTarget, "%Number.prototype%")
return NumberObject::create(global_object(), number.as_double()); return NumberObject::create(global_object, number.as_double());
} }
// 21.1.2.2 Number.isFinite ( number ), https://tc39.es/ecma262/#sec-number.isfinite // 21.1.2.2 Number.isFinite ( number ), https://tc39.es/ecma262/#sec-number.isfinite