RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 11:17:43 +00:00
Code Issues Activity Actions

LibWeb: Only return initialized navigables from child_navigables()

Browse source 
Fixes a crash in `get_session_history_entries()` that happens when
it attempts to find entries for a navigable that hasn't been fully
initialized and therefore doesn't have a nested history entry yet.
This commit is contained in:
Aliaksandr Kalenik 2023-09-01 22:13:30 +02:00 • committed by Andreas Kling
parent 15d265da65
commit fbc95440a4
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -62,6 +62,8 @@ Vector<JS::Handle<Navigable>> Navigable::child_navigables() const
{ {
Vector<JS::Handle<Navigable>> results; Vector<JS::Handle<Navigable>> results;
for (auto& entry : all_navigables()) { for (auto& entry : all_navigables()) {
if (entry->current_session_history_entry()->step == SessionHistoryEntry::Pending::Tag)
continue;
if (entry->parent() == this) if (entry->parent() == this)
results.append(entry); results.append(entry);
} }