From fbeef409c6029b0a8d2b51b0e64ca44f679844ed Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Sun, 10 Jul 2022 03:13:11 +0300 Subject: [PATCH] DynamicLoader: Stop performing relative relocations on non-pie objects Co-authored-by: Daniel Bertalan --- Userland/Libraries/LibELF/DynamicLoader.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Userland/Libraries/LibELF/DynamicLoader.cpp b/Userland/Libraries/LibELF/DynamicLoader.cpp index 7925b0dc66..6ea9ab82db 100644 --- a/Userland/Libraries/LibELF/DynamicLoader.cpp +++ b/Userland/Libraries/LibELF/DynamicLoader.cpp @@ -557,6 +557,8 @@ DynamicLoader::RelocationResult DynamicLoader::do_relocation(const ELF::DynamicO #else case R_X86_64_RELATIVE: { #endif + if (!image().is_dynamic()) + break; // FIXME: According to the spec, R_386_relative ones must be done first. // We could explicitly do them first using m_number_of_relocations from DT_RELCOUNT // However, our compiler is nice enough to put them at the front of the relocations for us :)