RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:07:34 +00:00
Code Issues Activity Actions

Inspector: Handle multi-packet RPC responses

Browse source 
This makes it possible to connect to Minesweeper, which has a rather
huge widget tree. :^)
This commit is contained in:
Andreas Kling 2020-03-05 16:02:20 +01:00
parent b2be8466fb
commit fbf345e03e
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
DevTools/Inspector/RemoteProcess.cpp
View file

@ -44,6 +44,7 @@ RemoteProcess::RemoteProcess(pid_t pid)
, m_socket(Core::LocalSocket::construct()) , m_socket(Core::LocalSocket::construct())
{ {
s_the = this; s_the = this;
m_socket->set_blocking(true);
} }
void RemoteProcess::handle_identify_response(const JsonObject& response) void RemoteProcess::handle_identify_response(const JsonObject& response)
@ -151,10 +152,19 @@ void RemoteProcess::update()
int nread = m_socket->read((u8*)&length, sizeof(length)); int nread = m_socket->read((u8*)&length, sizeof(length));
ASSERT(nread == sizeof(length)); ASSERT(nread == sizeof(length));
auto data = m_socket->read(length); ByteBuffer data;
ASSERT(data.size() == length); size_t remaining_bytes = length;
dbg() << "Got packet size " << length << " and read that many bytes"; while (remaining_bytes) {
auto packet = m_socket->read(remaining_bytes);
if (packet.size() == 0)
break;
data.append(packet.data(), packet.size());
remaining_bytes -= packet.size();
}
ASSERT(data.size() == length);
dbg() << "Got data size " << length << " and read that many bytes";
auto json_value = JsonValue::from_string(data); auto json_value = JsonValue::from_string(data);
ASSERT(json_value.is_object()); ASSERT(json_value.is_object());