RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibWeb: Add comparison operators to CSS numeric types (except Length)

Browse source 
This is to make it easier to bounds-check their values during parsing.
Length is left out because many length units are relative to the
context in which they are used, and so we cannot easily compare `10px`
and `1em`, for example.
This commit is contained in:
Sam Atkins 2023-05-31 14:55:18 +01:00 • committed by Andreas Kling
parent 06617a982e
commit fbfce2e73e
6 changed files with 69 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/CSS/Resolution.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022-2023, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -32,6 +32,18 @@ public:
return m_type == other.m_type && m_value == other.m_value;
}
int operator<=>(Resolution const& other) const
{
auto this_dots_per_pixel = to_dots_per_pixel();
auto other_dots_per_pixel = other.to_dots_per_pixel();
if (this_dots_per_pixel < other_dots_per_pixel)
return -1;
if (this_dots_per_pixel > other_dots_per_pixel)
return 1;
return 0;
}
private:
StringView unit_name() const;