RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

Refactor: Use ReadonlyBytes instead of const ReadonlyBytes&.

Browse source
This commit is contained in:
asynts 2020-08-15 18:47:25 +02:00 • committed by Andreas Kling
parent fff581cd72
commit fc276946fb
4 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibCrypto/Cipher/AES.cpp
View file

@ -396,10 +396,10 @@ void AESCipher::decrypt_block(const AESCipherBlock& in, AESCipherBlock& out)
// clang-format on // clang-format on
} }
void AESCipherBlock::overwrite(const ReadonlyBytes& span) void AESCipherBlock::overwrite(ReadonlyBytes bytes)
{ {
auto data = span.data(); auto data = bytes.data();
auto length = span.size(); auto length = bytes.size();
ASSERT(length <= m_data.size()); ASSERT(length <= m_data.size());
m_data.overwrite(0, data, length); m_data.overwrite(0, data, length);

4
Libraries/LibCrypto/Cipher/AES.h
View file

@ -54,8 +54,8 @@ public:
virtual ByteBuffer get() const override { return m_data; }; virtual ByteBuffer get() const override { return m_data; };
virtual const ByteBuffer& data() const override { return m_data; }; virtual const ByteBuffer& data() const override { return m_data; };
virtual void overwrite(const ReadonlyBytes&) override; virtual void overwrite(ReadonlyBytes) override;
virtual void overwrite(const ByteBuffer& buffer) override { overwrite(buffer.bytes()); } virtual void overwrite(const ByteBuffer& buffer) override { overwrite(buffer); }
virtual void overwrite(const u8* data, size_t size) override { overwrite({ data, size }); } virtual void overwrite(const u8* data, size_t size) override { overwrite({ data, size }); }
virtual void apply_initialization_vector(const u8* ivec) override virtual void apply_initialization_vector(const u8* ivec) override

4
Libraries/LibCrypto/Cipher/Cipher.h
View file

@ -64,8 +64,8 @@ public:
virtual ByteBuffer get() const = 0; virtual ByteBuffer get() const = 0;
virtual const ByteBuffer& data() const = 0; virtual const ByteBuffer& data() const = 0;
virtual void overwrite(const ReadonlyBytes&) = 0; virtual void overwrite(ReadonlyBytes) = 0;
virtual void overwrite(const ByteBuffer& buffer) { overwrite(buffer.bytes()); } virtual void overwrite(const ByteBuffer& buffer) { overwrite(buffer); }
virtual void overwrite(const u8* data, size_t size) { overwrite({ data, size }); } virtual void overwrite(const u8* data, size_t size) { overwrite({ data, size }); }
virtual void apply_initialization_vector(const u8* ivec) = 0; virtual void apply_initialization_vector(const u8* ivec) = 0;

2
Userland/test-crypto.cpp
View file

@ -99,7 +99,7 @@ static int crc32_tests();
// stop listing tests // stop listing tests
static void print_buffer(const ReadonlyBytes& buffer, int split) static void print_buffer(ReadonlyBytes buffer, int split)
{ {
for (size_t i = 0; i < buffer.size(); ++i) { for (size_t i = 0; i < buffer.size(); ++i) {
if (split > 0) { if (split > 0) {