RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 07:45:06 +00:00
Code Issues Activity Actions

LibWeb: Let BFC compute width for block-level replaced elements

Browse source 
We never really hit this code path before, but now that IMG elements can
be block-level, we need to get them hooked up with box model metrics.
This commit is contained in:
Andreas Kling 2022-04-11 01:04:09 +02:00
parent edfa4508a5
commit fc8c4ea23f
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -87,7 +87,7 @@ void BlockFormattingContext::compute_width(Box const& box, LayoutMode layout_mod
// FIXME: This const_cast is gross. // FIXME: This const_cast is gross.
const_cast<ReplacedBox&>(replaced).prepare_for_replaced_layout(); const_cast<ReplacedBox&>(replaced).prepare_for_replaced_layout();
compute_width_for_block_level_replaced_element_in_normal_flow(replaced); compute_width_for_block_level_replaced_element_in_normal_flow(replaced);
return; // NOTE: We don't return here.
} }
if (box.is_floating()) { if (box.is_floating()) {
@ -232,7 +232,10 @@ void BlockFormattingContext::compute_width(Box const& box, LayoutMode layout_mod
} }
auto& box_state = m_state.get_mutable(box); auto& box_state = m_state.get_mutable(box);
box_state.content_width = used_width.to_px(box);
if (!is<ReplacedBox>(box))
box_state.content_width = used_width.to_px(box);
box_state.margin_left = margin_left.to_px(box); box_state.margin_left = margin_left.to_px(box);
box_state.margin_right = margin_right.to_px(box); box_state.margin_right = margin_right.to_px(box);
box_state.border_left = computed_values.border_left().width; box_state.border_left = computed_values.border_left().width;