From fcc0530e26b50216d7d78567fa93a11107cc2ef1 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Fri, 11 Nov 2022 12:01:51 -0500 Subject: [PATCH] Ladybird: Stub out new cookie WebView::ViewImplementation APIs These were added for WebDriver, which doesn't have a Ladybird implementation yet. --- Ladybird/WebContentView.cpp | 14 ++++++++++++++ Ladybird/WebContentView.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/Ladybird/WebContentView.cpp b/Ladybird/WebContentView.cpp index 95a5abe442..18e9a16d8b 100644 --- a/Ladybird/WebContentView.cpp +++ b/Ladybird/WebContentView.cpp @@ -885,6 +885,16 @@ void WebContentView::notify_server_did_change_favicon(Gfx::Bitmap const& bitmap) emit favicon_changed(QIcon(qpixmap)); } +Vector WebContentView::notify_server_did_request_all_cookies(Badge, AK::URL const&) +{ + return {}; +} + +Optional WebContentView::notify_server_did_request_named_cookie(Badge, AK::URL const&, String const&) +{ + return {}; +} + String WebContentView::notify_server_did_request_cookie(Badge, AK::URL const& url, Web::Cookie::Source source) { if (on_get_cookie) @@ -898,6 +908,10 @@ void WebContentView::notify_server_did_set_cookie(Badge, AK::U on_set_cookie(url, cookie, source); } +void WebContentView::notify_server_did_update_cookie(Badge, AK::URL const&, Web::Cookie::Cookie const&) +{ +} + void WebContentView::notify_server_did_update_resource_count(i32 count_waiting) { // FIXME diff --git a/Ladybird/WebContentView.h b/Ladybird/WebContentView.h index 9171af333a..2a8b0baa60 100644 --- a/Ladybird/WebContentView.h +++ b/Ladybird/WebContentView.h @@ -134,8 +134,11 @@ public: virtual void notify_server_did_output_js_console_message(i32 message_index) override; virtual void notify_server_did_get_js_console_messages(i32 start_index, Vector const& message_types, Vector const& messages) override; virtual void notify_server_did_change_favicon(Gfx::Bitmap const& favicon) override; + virtual Vector notify_server_did_request_all_cookies(Badge, AK::URL const& url) override; + virtual Optional notify_server_did_request_named_cookie(Badge, AK::URL const& url, String const& name) override; virtual String notify_server_did_request_cookie(Badge, const AK::URL& url, Web::Cookie::Source source) override; virtual void notify_server_did_set_cookie(Badge, const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source) override; + virtual void notify_server_did_update_cookie(Badge, AK::URL const& url, Web::Cookie::Cookie const& cookie) override; virtual void notify_server_did_update_resource_count(i32 count_waiting) override; virtual void notify_server_did_request_restore_window() override; virtual Gfx::IntPoint notify_server_did_request_reposition_window(Gfx::IntPoint const&) override;