RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:37:45 +00:00
Code Issues Activity Actions

LibCore: Change Core::DateTime::parse to accept a StringView

Browse source 
No reason to force an allocation here, as we do not require a NUL-
terminated string.
This commit is contained in:
Timothy Flynn 2023-11-07 11:47:23 -05:00 • committed by Andreas Kling
parent 6655de189f
commit fd0075083a
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/DateTime.cpp
View file

@ -284,7 +284,7 @@ DeprecatedString DateTime::to_deprecated_string(StringView format) const
return MUST(to_string(format)).to_deprecated_string(); return MUST(to_string(format)).to_deprecated_string();
} }
Optional<DateTime> DateTime::parse(StringView format, DeprecatedString const& string) Optional<DateTime> DateTime::parse(StringView format, StringView string)
{ {
unsigned format_pos = 0; unsigned format_pos = 0;

2
Userland/Libraries/LibCore/DateTime.h
View file

@ -37,7 +37,7 @@ public:
static DateTime create(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0); static DateTime create(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0);
static DateTime now(); static DateTime now();
static DateTime from_timestamp(time_t); static DateTime from_timestamp(time_t);
static Optional<DateTime> parse(StringView format, DeprecatedString const& string); static Optional<DateTime> parse(StringView format, StringView string);
bool operator<(DateTime const& other) const { return m_timestamp < other.m_timestamp; } bool operator<(DateTime const& other) const { return m_timestamp < other.m_timestamp; }
bool operator==(DateTime const& other) const { return m_timestamp == other.m_timestamp; } bool operator==(DateTime const& other) const { return m_timestamp == other.m_timestamp; }