RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

LibWeb: Only invalidate styles if a @media rule changes match status

Browse source
This commit is contained in:
Sam Atkins 2022-02-17 12:34:36 +00:00 • committed by Andreas Kling
parent 144ef3eb9f
commit fd24782d85
5 changed files with 26 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1161,13 +1161,14 @@ void Document::evaluate_media_queries_and_report_changes()
}
// Also not in the spec, but this is as good a place as any to evaluate @media rules!
bool any_media_queries_changed_match_state = false;
for (auto& style_sheet : style_sheets().sheets()) {
style_sheet.evaluate_media_queries(window());
if (style_sheet.evaluate_media_queries(window()))
any_media_queries_changed_match_state = true;
}
// FIXME: This invalidates too often!
// We should only invalidate when one or more @media rules changes evaluation status.
style_computer().invalidate_rule_cache();
if (any_media_queries_changed_match_state)
style_computer().invalidate_rule_cache();
}
NonnullRefPtr<DOMImplementation> Document::implementation() const