RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:27:34 +00:00
Code Issues Activity Actions

LibX86: Correct CVTSS2SI's register signature

Browse source 
This was annotated the wrong way around.
This commit is contained in:
Hendiadyoin1 2022-04-05 12:24:42 +02:00 • committed by Andreas Kling
parent 7826729ab2
commit fd2af972ed
6 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/UserspaceEmulator/SoftCPU.cpp
View file

@ -2926,7 +2926,7 @@ VPU_INSTRUCTION(CVTPI2PS_xmm1_mm2m64);
VPU_INSTRUCTION(CVTSI2SS_xmm1_rm32);
VPU_INSTRUCTION(MOVNTPS_xmm1m128_xmm2);
VPU_INSTRUCTION(CVTPS2PI_xmm1_mm2m64);
VPU_INSTRUCTION(CVTSS2SI_xmm1_rm32);
VPU_INSTRUCTION(CVTSS2SI_r32_xmm2m32);
VPU_INSTRUCTION(UCOMISS_xmm1_xmm2m32);
VPU_INSTRUCTION(COMISS_xmm1_xmm2m32);
VPU_INSTRUCTION(MOVMSKPS_reg_xmm);

2
Userland/DevTools/UserspaceEmulator/SoftCPU.h
View file

@ -1133,7 +1133,7 @@ private:
virtual void CVTTPS2PI_mm1_xmm2m64(X86::Instruction const&) override;
virtual void CVTTSS2SI_r32_xmm2m32(X86::Instruction const&) override;
virtual void CVTPS2PI_xmm1_mm2m64(X86::Instruction const&) override;
virtual void CVTSS2SI_xmm1_rm32(X86::Instruction const&) override;
virtual void CVTSS2SI_r32_xmm2m32(X86::Instruction const&) override;
virtual void UCOMISS_xmm1_xmm2m32(X86::Instruction const&) override;
virtual void COMISS_xmm1_xmm2m32(X86::Instruction const&) override;
virtual void MOVMSKPS_reg_xmm(X86::Instruction const&) override;

2
Userland/DevTools/UserspaceEmulator/SoftVPU.cpp
View file

@ -218,7 +218,7 @@ void SoftVPU::CVTTSS2SI_r32_xmm2m32(X86::Instruction const& insn)
m_cpu.gpr32(insn.reg32()) = ValueWithShadow<u32>::create_initialized((u32)lround(value));
}
void SoftVPU::CVTPS2PI_xmm1_mm2m64(X86::Instruction const&) { TODO(); }
void SoftVPU::CVTSS2SI_xmm1_rm32(X86::Instruction const& insn)
void SoftVPU::CVTSS2SI_r32_xmm2m32(X86::Instruction const& insn)
{
// FIXME: Raise Invalid, Precision
insn.modrm().write32(m_cpu, insn,

2
Userland/DevTools/UserspaceEmulator/SoftVPU.h
View file

@ -127,7 +127,7 @@ private:
void CVTTPS2PI_mm1_xmm2m64(X86::Instruction const&);
void CVTTSS2SI_r32_xmm2m32(X86::Instruction const&);
void CVTPS2PI_xmm1_mm2m64(X86::Instruction const&);
void CVTSS2SI_xmm1_rm32(X86::Instruction const&);
void CVTSS2SI_r32_xmm2m32(X86::Instruction const&);
void UCOMISS_xmm1_xmm2m32(X86::Instruction const&);
void COMISS_xmm1_xmm2m32(X86::Instruction const&);
void MOVMSKPS_reg_xmm(X86::Instruction const&);

2
Userland/Libraries/LibX86/Instruction.cpp
View file

@ -869,7 +869,7 @@ static void build_sse_f3(u8 op, char const* mnemonic, InstructionFormat format,
build_sse_np(0x2C, "CVTTPS2PI", OP_mm1_xmm2m64, &Interpreter::CVTTPS2PI_mm1_xmm2m64);
build_sse_f3(0x2C, "CVTTSS2SI", OP_r32_xmm2m32, &Interpreter::CVTTSS2SI_r32_xmm2m32);
build_sse_np(0x2D, "CVTPS2PI", OP_mm1_xmm2m64, &Interpreter::CVTPS2PI_xmm1_mm2m64);
build_sse_f3(0x2D, "CVTSS2SI", OP_r32_xmm2m32, &Interpreter::CVTSS2SI_xmm1_rm32);
build_sse_f3(0x2D, "CVTSS2SI", OP_r32_xmm2m32, &Interpreter::CVTSS2SI_r32_xmm2m32);
build_sse_np(0x2E, "UCOMISS", OP_xmm1_xmm2m32, &Interpreter::UCOMISS_xmm1_xmm2m32);
build_sse_np(0x2F, "COMISS", OP_xmm1_xmm2m32, &Interpreter::COMISS_xmm1_xmm2m32);

2
Userland/Libraries/LibX86/Interpreter.h
View file

@ -681,7 +681,7 @@ public:
virtual void CVTSI2SS_xmm1_rm32(Instruction const&) = 0;
virtual void MOVNTPS_xmm1m128_xmm2(Instruction const&) = 0;
virtual void CVTPS2PI_xmm1_mm2m64(Instruction const&) = 0;
virtual void CVTSS2SI_xmm1_rm32(Instruction const&) = 0;
virtual void CVTSS2SI_r32_xmm2m32(Instruction const&) = 0;
virtual void UCOMISS_xmm1_xmm2m32(Instruction const&) = 0;
virtual void COMISS_xmm1_xmm2m32(Instruction const&) = 0;
virtual void MOVMSKPS_reg_xmm(Instruction const&) = 0;