RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:37:34 +00:00
Code Issues Activity Actions

LibWeb: Use Core::Timer instead for animation driver timer

Browse source 
Platform::Timer uses JS::SafeFunction that prevents document from ever
being deallocated because of strong reference.
This commit is contained in:
Aliaksandr Kalenik 2024-03-11 03:58:47 +01:00 • committed by Andreas Kling
parent 2129c5d8b0
commit fd63ffb8c3
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -4023,7 +4023,7 @@ void Document::ensure_animation_timer()
{ {
constexpr static auto timer_delay_ms = 1000 / 60; constexpr static auto timer_delay_ms = 1000 / 60;
if (!m_animation_driver_timer) { if (!m_animation_driver_timer) {
m_animation_driver_timer = Platform::Timer::create_repeating(timer_delay_ms, [this] { m_animation_driver_timer = MUST(Core::Timer::create_repeating(timer_delay_ms, [this] {
bool has_animations = false; bool has_animations = false;
for (auto& timeline : m_associated_animation_timelines) { for (auto& timeline : m_associated_animation_timelines) {
if (!timeline->associated_animations().is_empty()) { if (!timeline->associated_animations().is_empty()) {
@ -4042,7 +4042,7 @@ void Document::ensure_animation_timer()
for (auto& animation : timeline->associated_animations()) for (auto& animation : timeline->associated_animations())
dispatch_events_for_animation_if_necessary(animation); dispatch_events_for_animation_if_necessary(animation);
} }
}); }));
} }
m_animation_driver_timer->start(); m_animation_driver_timer->start();

2
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -828,7 +828,7 @@ private:
// https://www.w3.org/TR/web-animations-1/#pending-animation-event-queue // https://www.w3.org/TR/web-animations-1/#pending-animation-event-queue
Vector<PendingAnimationEvent> m_pending_animation_event_queue; Vector<PendingAnimationEvent> m_pending_animation_event_queue;
RefPtr<Platform::Timer> m_animation_driver_timer; RefPtr<Core::Timer> m_animation_driver_timer;
bool m_needs_to_call_page_did_load { false }; bool m_needs_to_call_page_did_load { false };