RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

AK: Add take_first to HashTable and rename pop to take_last

Browse source 
This naming scheme matches Vector.

This also changes `take_last` to move the value it takes, and delete by
known pointer, avoiding a full lookup and potential copies.
This commit is contained in:
Hediadyoin1 2023-02-21 11:30:52 +01:00 • committed by Jelle Raaijmakers
parent 93945062a7
commit fd8c54d720
3 changed files with 45 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Tests/AK/TestHashTable.cpp
View file

@ -358,16 +358,16 @@ TEST_CASE(ordered_deletion_and_reinsertion)
EXPECT_EQ(it, table.end());
}
TEST_CASE(ordered_pop)
TEST_CASE(ordered_take_last)
{
OrderedHashTable<int> table;
table.set(1);
table.set(2);
table.set(3);
EXPECT_EQ(table.pop(), 3);
EXPECT_EQ(table.pop(), 2);
EXPECT_EQ(table.pop(), 1);
EXPECT_EQ(table.take_last(), 3);
EXPECT_EQ(table.take_last(), 2);
EXPECT_EQ(table.take_last(), 1);
EXPECT(table.is_empty());
}
@ -382,3 +382,31 @@ TEST_CASE(ordered_iterator_removal)
EXPECT_EQ(it, map.end());
EXPECT_EQ(map.size(), 1u);
}
TEST_CASE(ordered_remove_from_head)
{
OrderedHashTable<int> map;
map.set(1);
map.set(2);
map.set(3);
map.set(4);
map.set(5);
map.set(6);
EXPECT_EQ(map.size(), 6u);
auto it = map.begin();
map.remove(it);
it = map.begin();
map.remove(it);
it = map.begin();
map.remove(it);
it = map.begin();
map.remove(it);
it = map.begin();
map.remove(it);
it = map.begin();
map.remove(it);
EXPECT_EQ(map.size(), 0u);
}