From fded8f861d7576ceffc818c43bdd62285b569ad0 Mon Sep 17 00:00:00 2001 From: sin-ack Date: Mon, 11 Jul 2022 20:33:16 +0000 Subject: [PATCH] Tests: Convert TestQuotedPrintable decode test to use StringViews --- Tests/LibIMAP/TestQuotedPrintable.cpp | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/Tests/LibIMAP/TestQuotedPrintable.cpp b/Tests/LibIMAP/TestQuotedPrintable.cpp index 92171bd376..a279818cf2 100644 --- a/Tests/LibIMAP/TestQuotedPrintable.cpp +++ b/Tests/LibIMAP/TestQuotedPrintable.cpp @@ -10,29 +10,29 @@ TEST_CASE(test_decode) { - auto decode_equal = [](char const* input, char const* expected) { - auto decoded = IMAP::decode_quoted_printable(StringView(input)); - EXPECT(String::copy(decoded) == String(expected)); + auto decode_equal = [](StringView input, StringView expected) { + auto decoded = IMAP::decode_quoted_printable(input); + EXPECT(decoded.bytes() == expected.bytes()); }; - auto decode_equal_byte_buffer = [](char const* input, char const* expected, size_t expected_length) { - auto decoded = IMAP::decode_quoted_printable(StringView(input)); - EXPECT(decoded == ByteBuffer::copy(expected, expected_length).value()); + auto decode_equal_byte_buffer = [](StringView input, StringView expected) { + auto decoded = IMAP::decode_quoted_printable(input); + EXPECT(decoded.bytes() == expected.bytes()); }; - decode_equal("hello world", "hello world"); - decode_equal("=3D", "="); - decode_equal("hello=\r\n world", "hello world"); - decode_equal("=68=65=6C=6C=6F=20=\r\n=77=6F=72=6C=64", "hello world"); + decode_equal("hello world"sv, "hello world"sv); + decode_equal("=3D"sv, "="sv); + decode_equal("hello=\r\n world"sv, "hello world"sv); + decode_equal("=68=65=6C=6C=6F=20=\r\n=77=6F=72=6C=64"sv, "hello world"sv); // Doesn't mistake hex sequences without a preceding '=' as an escape sequence. - decode_equal("4A=4B=4C4D", "4AKL4D"); + decode_equal("4A=4B=4C4D"sv, "4AKL4D"sv); // Allows lowercase escape sequences. - decode_equal("=4a=4b=4c=4d=4e=4f", "JKLMNO"); + decode_equal("=4a=4b=4c=4d=4e=4f"sv, "JKLMNO"sv); // Bytes for U+1F41E LADY BEETLE - decode_equal_byte_buffer("=F0=9F=90=9E", "\xF0\x9F\x90\x9E", 4); + decode_equal_byte_buffer("=F0=9F=90=9E"sv, "\xF0\x9F\x90\x9E"sv); // Illegal characters. If these aren't escaped, they are simply ignored. // Illegal characters are: