RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:07:36 +00:00
Code Issues Activity Actions

AK: Simplify const T& versions of append/insert in SinglyLinkedList

Browse source
This commit is contained in:
Conrad Pankoff 2019-12-27 12:14:12 +11:00 • committed by Andreas Kling
parent 115b315375
commit fe3311d458
1 changed files with 3 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

29
AK/SinglyLinkedList.h
View file

@ -107,14 +107,7 @@ public:
void append(const T& value) void append(const T& value)
{ {
auto* node = new Node(value); append(T(value));
if (!m_head) {
m_head = node;
m_tail = node;
return;
}
m_tail->next = node;
m_tail = node;
} }
void append(T&& value) void append(T&& value)
@ -196,12 +189,7 @@ public:
void insert_before(Iterator iterator, const T& value) void insert_before(Iterator iterator, const T& value)
{ {
auto* node = new Node(value); insert_before(T(value));
node->next = iterator.m_node;
if (m_head == iterator.m_node)
m_head = node;
if (iterator.m_prev)
iterator.m_prev->next = node;
} }
void insert_before(Iterator iterator, T&& value) void insert_before(Iterator iterator, T&& value)
@ -216,18 +204,7 @@ public:
void insert_after(Iterator iterator, const T& value) void insert_after(Iterator iterator, const T& value)
{ {
if (iterator.is_end()) { insert_after(T(value));
append(value);
return;
}
auto* node = new Node(value);
node->next = iterator.m_node->next;
iterator.m_node->next = node;
if (m_tail == iterator.m_node)
m_tail = node;
} }
void insert_after(Iterator iterator, T&& value) void insert_after(Iterator iterator, T&& value)