RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 23:38:12 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibGUI

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:50:04 -07:00 • committed by Brian Gianforcaro
parent b801ddf73d
commit fe3b846ac8
146 changed files with 271 additions and 462 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibGUI/ColorPicker.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -22,7 +23,7 @@ class ColorButton : public AbstractButton {
C_OBJECT(ColorButton);
public:
virtual ~ColorButton() override;
virtual ~ColorButton() override = default;
void set_selected(bool selected);
Color color() const { return m_color; }
@ -146,7 +147,7 @@ public:
return m_col;
}
virtual ~ColorSelectOverlay() override { }
virtual ~ColorSelectOverlay() override = default;
Function<void(Color)> on_color_changed;
private:
@ -193,10 +194,6 @@ ColorPicker::ColorPicker(Color color, Window* parent_window, String title)
build_ui();
}
ColorPicker::~ColorPicker()
{
}
void ColorPicker::set_color_has_alpha_channel(bool has_alpha)
{
if (m_color_has_alpha_channel == has_alpha)
@ -458,10 +455,6 @@ ColorButton::ColorButton(ColorPicker& picker, Color color)
m_color = color;
}
ColorButton::~ColorButton()
{
}
void ColorButton::set_selected(bool selected)
{
m_selected = selected;