RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:47:35 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibGUI

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:50:04 -07:00 • committed by Brian Gianforcaro
parent b801ddf73d
commit fe3b846ac8
146 changed files with 271 additions and 462 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibGUI/TextDocument.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -40,7 +41,7 @@ public:
class Client {
public:
virtual ~Client();
virtual ~Client() = default;
virtual void document_did_append_line() = 0;
virtual void document_did_insert_line(size_t) = 0;
virtual void document_did_remove_line(size_t) = 0;
@ -55,7 +56,7 @@ public:
};
static NonnullRefPtr<TextDocument> create(Client* client = nullptr);
virtual ~TextDocument();
virtual ~TextDocument() = default;
size_t line_count() const { return m_lines.size(); }
const TextDocumentLine& line(size_t line_index) const { return m_lines[line_index]; }
@ -187,7 +188,7 @@ private:
class TextDocumentUndoCommand : public Command {
public:
TextDocumentUndoCommand(TextDocument&);
virtual ~TextDocumentUndoCommand();
virtual ~TextDocumentUndoCommand() = default;
virtual void perform_formatting(const TextDocument::Client&) { }
void execute_from(const TextDocument::Client& client)