RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 08:37:35 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibGUI

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:50:04 -07:00 • committed by Brian Gianforcaro
parent b801ddf73d
commit fe3b846ac8
146 changed files with 271 additions and 462 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibGUI/Wizards/AbstractWizardPage.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -8,14 +9,6 @@
namespace GUI {
AbstractWizardPage::AbstractWizardPage()
{
}
AbstractWizardPage::~AbstractWizardPage()
{
}
RefPtr<AbstractWizardPage> AbstractWizardPage::next_page()
{
if (on_next_page)

4
Userland/Libraries/LibGUI/Wizards/AbstractWizardPage.h
View file

@ -15,7 +15,7 @@ class AbstractWizardPage : public Widget {
C_OBJECT_ABSTRACT(AbstractWizardPage);
public:
virtual ~AbstractWizardPage() override;
virtual ~AbstractWizardPage() override = default;
Function<RefPtr<AbstractWizardPage>()> on_next_page;
virtual RefPtr<AbstractWizardPage> next_page();
@ -31,7 +31,7 @@ public:
void set_is_final_page(bool val) { m_is_final_page = val; }
protected:
AbstractWizardPage();
AbstractWizardPage() = default;
private:
bool m_is_final_page { false };

5
Userland/Libraries/LibGUI/Wizards/WizardDialog.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -78,10 +79,6 @@ WizardDialog::WizardDialog(Window* parent_window)
update_navigation();
}
WizardDialog::~WizardDialog()
{
}
void WizardDialog::push_page(AbstractWizardPage& page)
{
if (!m_page_stack.is_empty())

3
Userland/Libraries/LibGUI/Wizards/WizardDialog.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -15,7 +16,7 @@ namespace GUI {
class WizardDialog : public Dialog {
C_OBJECT(WizardDialog)
public:
virtual ~WizardDialog() override;
virtual ~WizardDialog() override = default;
static void show(AbstractWizardPage& first_page, Window* parent_window = nullptr)
{