1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:17:46 +00:00

Meta: Fix shellcheck warnings in various scripts

Warnings fixed:
 * SC2086: Double quote to prevent globbing and word splitting.
 * SC2006: Use $(...) notation instead of legacy backticked `...`
 * SC2039: In POSIX sh, echo flags are undefined
 * SC2209: Use var=$(command) to assign output (or quote to assign string)
 * SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails
 * SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
 * SC2034: i appears unused. Verify use (or export if used externally)
 * SC2046: Quote this to prevent word splitting.
 * SC2236: Use -z instead of ! -n.

There are still a lot of warnings in Kernel/run about:
 - SC2086: Double quote to prevent globbing and word splitting.

However, splitting on space is intentional in this case, and not trivial to
change. Therefore ignore the warning for now - but we should fix this in
the future.
This commit is contained in:
Shannon Booth 2020-02-10 19:09:08 +13:00 committed by Andreas Kling
parent e9be8669d2
commit fe668db999
6 changed files with 28 additions and 23 deletions

View file

@ -9,7 +9,7 @@ while [ "$1" != "" ]; do
case $1 in
-f | --fast ) fast_mode=1
;;
-h | --help ) echo "-f or --fast: build fast without cleaning or running tests"
-h | --help ) printf -- "-f or --fast: build fast without cleaning or running tests\n"
exit 0
;;
esac
@ -18,10 +18,10 @@ done
sudo id
MAKE=make
MAKE="make"
if [ "$(uname -s)" = "OpenBSD" ]; then
MAKE=gmake
MAKE="gmake"
fi
if [ "$fast_mode" = "1" ]; then