RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:34:59 +00:00
Code Issues Activity Actions

Meta: Fix shellcheck warnings in various scripts

Browse source 
Warnings fixed:
 * SC2086: Double quote to prevent globbing and word splitting.
 * SC2006: Use $(...) notation instead of legacy backticked `...`
 * SC2039: In POSIX sh, echo flags are undefined
 * SC2209: Use var=$(command) to assign output (or quote to assign string)
 * SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails
 * SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
 * SC2034: i appears unused. Verify use (or export if used externally)
 * SC2046: Quote this to prevent word splitting.
 * SC2236: Use -z instead of ! -n.

There are still a lot of warnings in Kernel/run about:
 - SC2086: Double quote to prevent globbing and word splitting.

However, splitting on space is intentional in this case, and not trivial to
change. Therefore ignore the warning for now - but we should fix this in
the future.
This commit is contained in:
Shannon Booth 2020-02-10 19:09:08 +13:00 • committed by Andreas Kling
parent e9be8669d2
commit fe668db999
6 changed files with 28 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Meta/refresh-serenity-qtcreator.sh
View file

@ -1,6 +1,6 @@
#!/bin/sh
if [ ! -n "$SERENITY_ROOT" ]
if [ -z "$SERENITY_ROOT" ]
then echo "Serenity root not set. Please set environment variable first. E.g. export SERENITY_ROOT=$(git rev-parse --show-toplevel)"
fi