RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:27:45 +00:00
Code Issues Activity Actions

PixelPaint: Extract common scope code into a generic ScopeWidget

Browse source 
When we add more scopes, this will facilitate code sharing.
This commit is contained in:
kleines Filmröllchen 2022-08-16 22:43:11 +02:00 • committed by Linus Groh
parent 8b60305698
commit fe88fd22fa
5 changed files with 86 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Userland/Applications/PixelPaint/HistogramWidget.cpp
View file

@ -16,25 +16,6 @@ REGISTER_WIDGET(PixelPaint, HistogramWidget);
namespace PixelPaint {
HistogramWidget::~HistogramWidget()
{
if (m_image)
m_image->remove_client(*this);
}
void HistogramWidget::set_image(Image* image)
{
if (m_image == image)
return;
if (m_image)
m_image->remove_client(*this);
m_image = image;
if (m_image)
m_image->add_client(*this);
(void)rebuild_histogram_data();
}
ErrorOr<void> HistogramWidget::rebuild_histogram_data()
{
if (!m_image)
@ -81,16 +62,15 @@ ErrorOr<void> HistogramWidget::rebuild_histogram_data()
}
// Scale the frequency values to fit the widgets height.
m_widget_height = height();
auto widget_height = height();
for (int i = 0; i < 256; i++) {
m_data.red[i] = m_data.red[i] != 0 ? (static_cast<float>(m_data.red[i]) / max_color_frequency) * m_widget_height : 0;
m_data.green[i] = m_data.green[i] != 0 ? (static_cast<float>(m_data.green[i]) / max_color_frequency) * m_widget_height : 0;
m_data.blue[i] = m_data.blue[i] != 0 ? (static_cast<float>(m_data.blue[i]) / max_color_frequency) * m_widget_height : 0;
m_data.brightness[i] = m_data.brightness[i] != 0 ? (static_cast<float>(m_data.brightness[i]) / max_brightness_frequency) * m_widget_height : 0;
m_data.red[i] = m_data.red[i] != 0 ? (static_cast<float>(m_data.red[i]) / max_color_frequency) * widget_height : 0;
m_data.green[i] = m_data.green[i] != 0 ? (static_cast<float>(m_data.green[i]) / max_color_frequency) * widget_height : 0;
m_data.blue[i] = m_data.blue[i] != 0 ? (static_cast<float>(m_data.blue[i]) / max_color_frequency) * widget_height : 0;
m_data.brightness[i] = m_data.brightness[i] != 0 ? (static_cast<float>(m_data.brightness[i]) / max_brightness_frequency) * widget_height : 0;
}
update();
return {};
}
@ -102,7 +82,7 @@ void HistogramWidget::paint_event(GUI::PaintEvent& event)
if (!m_image)
return;
int bottom_line = m_widget_height - 1;
int bottom_line = height() - 1;
float step_width = static_cast<float>(width()) / 256;
Gfx::Path brightness_path;
@ -153,14 +133,6 @@ void HistogramWidget::paint_event(GUI::PaintEvent& event)
void HistogramWidget::image_changed()
{
(void)rebuild_histogram_data();
}
void HistogramWidget::set_color_at_mouseposition(Color color)
{
if (m_color_at_mouseposition == color)
return;
m_color_at_mouseposition = color;
update();
}