From fea181bde35b115de33adb5f80c3f6abe46cec72 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 12 Aug 2021 22:19:14 -0400 Subject: [PATCH] LibRegex: Reduce RegexMatcher's BumpAllocator chunk size Before the BumpAllocator OOB access issue was understood and fixed, the chunk size was increased to 8MiB as a workaround in commit: 27d555bab0d84913599cea3c4a6b0a0ed2a15b66. The issue is now resolved by: 0f1425c895ace40fbb10d68a55eeb3a6354479d3. We can reduce the chunk size to 2MiB, which has the added benefit of reducing runtime of the RegExp.prototype.exec test. --- Userland/Libraries/LibRegex/RegexMatcher.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibRegex/RegexMatcher.cpp b/Userland/Libraries/LibRegex/RegexMatcher.cpp index 6b6ce96c71..c312ca3c81 100644 --- a/Userland/Libraries/LibRegex/RegexMatcher.cpp +++ b/Userland/Libraries/LibRegex/RegexMatcher.cpp @@ -391,7 +391,7 @@ private: Node* previous { nullptr }; }; - UniformBumpAllocator m_allocator; + UniformBumpAllocator m_allocator; Node* m_first { nullptr }; Node* m_last { nullptr }; };