RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:07:34 +00:00
Code Issues Activity Actions

LibPDF: Ask OpenType font programs for glyph widths if needed

Browse source 
If the font dictionary didn't specify custom glyph widths, we would fall
back to the specified "missing width" (or 0 in most cases!), which meant
that we would draw glyphs on top of each other in a lot of cases, namely
for TrueTypeFonts or standard Type1Fonts with an OpenType fallback.

What we actually want to do in this case is ask the OpenType font for
the correct width.
This commit is contained in:
Julian Offenhäuser 2023-03-24 22:22:33 +01:00 • committed by Andrew Kaster
parent 2b3a41be74
commit fec7ccf020
6 changed files with 21 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibPDF/Fonts/SimpleFont.h
View file

@ -17,13 +17,12 @@ public:
protected:
PDFErrorOr<void> initialize(Document* document, NonnullRefPtr<DictObject> const& dict, float font_size) override;
virtual float get_glyph_width(u8 char_code) const = 0;
virtual void draw_glyph(Gfx::Painter& painter, Gfx::FloatPoint point, float width, u8 char_code, Color color) = 0;
RefPtr<Encoding>& encoding() { return m_encoding; }
RefPtr<Encoding> const& encoding() const { return m_encoding; }
private:
float get_char_width(u8 char_code) const;
RefPtr<Encoding> m_encoding;
RefPtr<StreamObject> m_to_unicode;
HashMap<u8, u16> m_widths;