RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:22:45 +00:00
Code Issues Activity Actions

LibWeb: Move set_scroll_offset() from Layout::Box to PaintableBox

Browse source 
Nodes in layout tree should not be aware of scroll state.
This commit is contained in:
Aliaksandr Kalenik 2023-08-06 21:10:15 +02:00 • committed by Andreas Kling
parent 5b7926fa53
commit fee5b4deb6
5 changed files with 24 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -71,6 +71,26 @@ CSSPixelPoint PaintableBox::scroll_offset() const
return static_cast<DOM::Element const*>(dom_node())->scroll_offset(DOM::Element::ScrollOffsetFor::Self);
}
void PaintableBox::set_scroll_offset(CSSPixelPoint offset)
{
// FIXME: If there is horizontal and vertical scroll ignore only part of the new offset
if (offset.y() < 0 || scroll_offset() == offset)
return;
auto& node = layout_node();
if (node.is_generated_for_before_pseudo_element()) {
node.pseudo_element_generator()->set_scroll_offset(DOM::Element::ScrollOffsetFor::PseudoBefore, offset);
} else if (node.is_generated_for_after_pseudo_element()) {
node.pseudo_element_generator()->set_scroll_offset(DOM::Element::ScrollOffsetFor::PseudoAfter, offset);
} else if (is<DOM::Element>(*dom_node())) {
static_cast<DOM::Element*>(dom_node())->set_scroll_offset(DOM::Element::ScrollOffsetFor::Self, offset);
} else {
return;
}
node.set_needs_display();
}
void PaintableBox::scroll_by(int delta_x, int delta_y)
{
auto scrollable_overflow_rect = this->scrollable_overflow_rect();
@ -81,7 +101,7 @@ void PaintableBox::scroll_by(int delta_x, int delta_y)
auto current_offset = scroll_offset();
auto new_offset_x = clamp(current_offset.x() + delta_x, 0, max_x_offset);
auto new_offset_y = clamp(current_offset.y() + delta_y, 0, max_y_offset);
layout_box().set_scroll_offset({ new_offset_x, new_offset_y });
set_scroll_offset({ new_offset_x, new_offset_y });
}
void PaintableBox::set_offset(CSSPixelPoint offset)