From ff16da8c771f85f96fa289ecabd18b2137ec985b Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Tue, 11 Aug 2020 23:47:18 +0200 Subject: [PATCH] Kernel: Module symbol declarations for type-checking With this, if a future module misses the 'extern "C"' or uses a wrong type, they get a nice compiler error instead of runtime errors or weird behavior. Also, this works towards getting the Kernel ready for -Wmissing-declarations. --- Kernel/Modules/TestModule.cpp | 3 ++- Kernel/Modules/module_syms.h | 31 +++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 Kernel/Modules/module_syms.h diff --git a/Kernel/Modules/TestModule.cpp b/Kernel/Modules/TestModule.cpp index 3be421c934..06dae5f727 100644 --- a/Kernel/Modules/TestModule.cpp +++ b/Kernel/Modules/TestModule.cpp @@ -24,7 +24,8 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include +#include +#include extern "C" const char module_name[] = "TestModule"; diff --git a/Kernel/Modules/module_syms.h b/Kernel/Modules/module_syms.h new file mode 100644 index 0000000000..f8f4e5a9d1 --- /dev/null +++ b/Kernel/Modules/module_syms.h @@ -0,0 +1,31 @@ +/* + * Copyright (c) 2020, the SerenityOS developers. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#pragma once + +extern "C" const char module_name[]; +extern "C" void module_init(); +extern "C" void module_fini();