RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

Solitaire: Make auto_move_eligible_cards_to_foundations() iterative

Browse source 
This doesn't need to be recursive, so let's make it not so.
This commit is contained in:
Sam Atkins 2022-09-29 11:27:17 +01:00 • committed by Sam Atkins
parent 5186e617bd
commit ff175389ab
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Games/Solitaire/Game.cpp
View file

@ -486,19 +486,19 @@ bool Game::attempt_to_move_card_to_foundations(CardStack& from)
void Game::auto_move_eligible_cards_to_foundations() void Game::auto_move_eligible_cards_to_foundations()
{ {
bool card_was_moved = false; while (true) {
bool card_was_moved = false;
for (auto& to_check : stacks()) {
if (to_check.type() != CardStack::Type::Normal && to_check.type() != CardStack::Type::Play)
continue;
for (auto& to_check : stacks()) { if (attempt_to_move_card_to_foundations(to_check))
if (to_check.type() != CardStack::Type::Normal && to_check.type() != CardStack::Type::Play) card_was_moved = true;
continue; }
if (attempt_to_move_card_to_foundations(to_check)) if (!card_was_moved)
card_was_moved = true; break;
} }
// If at least one card was moved, check again to see if now any additional cards can now be moved
if (card_was_moved)
auto_move_eligible_cards_to_foundations();
} }
void Game::paint_event(GUI::PaintEvent& event) void Game::paint_event(GUI::PaintEvent& event)