RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:17:45 +00:00
Code Issues Activity Actions

LibCore: Make NetworkJob::start() take a Stream::BufferedSocketBase&

Browse source 
It used to take a plain `Socket` and cast it to a `BufferedSocketBase`,
which can lead to unpleasant result when used with a non-buffered
`Socket`.
This commit is contained in:
Lucas CHOLLET 2023-02-09 19:07:11 -05:00 • committed by Jelle Raaijmakers
parent 5fc873f53b
commit ff47223301
6 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/NetworkJob.h
View file

@ -41,7 +41,7 @@ public:
DetachFromSocket,
CloseSocket,
};
virtual void start(Core::Socket&) = 0;
virtual void start(Core::BufferedSocketBase&) = 0;
virtual void shutdown(ShutdownMode) = 0;
virtual void fail(Error error) { did_fail(error); }