RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 07:37:46 +00:00
Code Issues Activity Actions

LibCore: Make NetworkJob::start() take a Stream::BufferedSocketBase&

Browse source 
It used to take a plain `Socket` and cast it to a `BufferedSocketBase`,
which can lead to unpleasant result when used with a non-buffered
`Socket`.
This commit is contained in:
Lucas CHOLLET 2023-02-09 19:07:11 -05:00 • committed by Jelle Raaijmakers
parent 5fc873f53b
commit ff47223301
6 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGemini/Job.cpp
View file

@ -20,10 +20,10 @@ Job::Job(GeminiRequest const& request, Stream& output_stream)
{
}
void Job::start(Core::Socket& socket)
void Job::start(Core::BufferedSocketBase& socket)
{
VERIFY(!m_socket);
m_socket = verify_cast<Core::BufferedSocketBase>(&socket);
m_socket = &socket;
on_socket_connected();
}

2
Userland/Libraries/LibGemini/Job.h
View file

@ -21,7 +21,7 @@ public:
explicit Job(GeminiRequest const&, Stream&);
virtual ~Job() override = default;
virtual void start(Core::Socket&) override;
virtual void start(Core::BufferedSocketBase&) override;
virtual void shutdown(ShutdownMode) override;
GeminiResponse* response() { return static_cast<GeminiResponse*>(Core::NetworkJob::response()); }