RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:27:45 +00:00
Code Issues Activity Actions

Profiler: Don't change window title based on last enabled option

Browse source 
This behavior was bizarre and only highlighted whichever setting
was the last one to be activated.
This commit is contained in:
Andreas Kling 2021-04-10 15:54:12 +02:00
parent 53ed30a9f5
commit ff52a0f90b
1 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/DevTools/Profiler/main.cpp
View file

@ -146,26 +146,14 @@ int main(int argc, char** argv)
auto& view_menu = menubar->add_menu("View"); auto& view_menu = menubar->add_menu("View");
auto update_window_title = [&](auto title, bool is_checked) {
StringBuilder name;
name.append("Profiler");
if (is_checked) {
name.append(" - ");
name.append(title);
}
window->set_title(name.to_string());
};
auto invert_action = GUI::Action::create_checkable("Invert tree", { Mod_Ctrl, Key_I }, [&](auto& action) { auto invert_action = GUI::Action::create_checkable("Invert tree", { Mod_Ctrl, Key_I }, [&](auto& action) {
profile->set_inverted(action.is_checked()); profile->set_inverted(action.is_checked());
update_window_title("Invert tree", action.is_checked());
}); });
invert_action->set_checked(false); invert_action->set_checked(false);
view_menu.add_action(invert_action); view_menu.add_action(invert_action);
auto top_functions_action = GUI::Action::create_checkable("Top functions", { Mod_Ctrl, Key_T }, [&](auto& action) { auto top_functions_action = GUI::Action::create_checkable("Top functions", { Mod_Ctrl, Key_T }, [&](auto& action) {
profile->set_show_top_functions(action.is_checked()); profile->set_show_top_functions(action.is_checked());
update_window_title("Top functions", action.is_checked());
}); });
top_functions_action->set_checked(false); top_functions_action->set_checked(false);
view_menu.add_action(top_functions_action); view_menu.add_action(top_functions_action);
@ -174,7 +162,6 @@ int main(int argc, char** argv)
profile->set_show_percentages(action.is_checked()); profile->set_show_percentages(action.is_checked());
tree_view.update(); tree_view.update();
disassembly_view.update(); disassembly_view.update();
update_window_title("Show percentages", action.is_checked());
}); });
percent_action->set_checked(false); percent_action->set_checked(false);
view_menu.add_action(percent_action); view_menu.add_action(percent_action);