RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 18:17:34 +00:00
Code Issues Activity Actions

LibWeb: Add a FlyString version of Element::tag_name

Browse source 
Renaming the DeprecatedString version of this function to
deprecated_tag_name. A FlyString is used here as we often need to
perform equality checks here, and the HTMLParser already has tag_name as
a FlyString.

Remove a FIXME while we're at it - we were already following the spec
there, and we still are :^)
This commit is contained in:
Shannon Booth 2023-10-02 01:44:25 +13:00 • committed by Sam Atkins
parent 9303e9e76f
commit ff72436448
4 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -1183,7 +1183,7 @@ Messages::WebDriverClient::GetElementTagNameResponse WebDriverConnection::get_el
auto qualified_name = element->tag_name();
// 5. Return success with data qualified name.
return qualified_name;
return MUST(JsonValue::from_string(qualified_name));
}
// 12.4.7 Get Element Rect, https://w3c.github.io/webdriver/#dfn-get-element-rect