From ffb569fd5d2c37d0721693ef4e8ea2038eb2f68e Mon Sep 17 00:00:00 2001 From: Matthew Olsson Date: Mon, 6 Jul 2020 17:02:06 -0700 Subject: [PATCH] LibJS: Uncomment remaining symbol tests --- .../LibJS/Tests/builtins/Symbol/Symbol.for.js | 40 ++++++++--------- .../Tests/builtins/Symbol/Symbol.keyFor.js | 44 +++++++++---------- 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/Libraries/LibJS/Tests/builtins/Symbol/Symbol.for.js b/Libraries/LibJS/Tests/builtins/Symbol/Symbol.for.js index b4e37e3c6c..c905be3c72 100644 --- a/Libraries/LibJS/Tests/builtins/Symbol/Symbol.for.js +++ b/Libraries/LibJS/Tests/builtins/Symbol/Symbol.for.js @@ -1,23 +1,23 @@ -// test("basic functionality", () => { -// const localSym = Symbol("foo"); -// const globalSym = Symbol.for("foo"); +test("basic functionality", () => { + const localSym = Symbol("foo"); + const globalSym = Symbol.for("foo"); -// expect(localSym).not.toBe(globalSym); -// expect(localSym).not.toBe(Symbol("foo")); -// expect(globalSym).not.toBe(Symbol("foo")); -// expect(globalSym).toBe(Symbol.for("foo")); -// expect(localSym.toString()).toBe("Symbol(foo)"); -// expect(globalSym.toString()).toBe("Symbol(foo)"); + expect(localSym).not.toBe(globalSym); + expect(localSym).not.toBe(Symbol("foo")); + expect(globalSym).not.toBe(Symbol("foo")); + expect(globalSym).toBe(Symbol.for("foo")); + expect(localSym.toString()).toBe("Symbol(foo)"); + expect(globalSym.toString()).toBe("Symbol(foo)"); -// expect(Symbol.for(1).description).toBe("1"); -// expect(Symbol.for(true).description).toBe("true"); -// expect(Symbol.for({}).description).toBe("[object Object]"); -// expect(Symbol.for().description).toBe("undefined"); -// expect(Symbol.for(null).description).toBe("null"); -// }); + expect(Symbol.for(1).description).toBe("1"); + expect(Symbol.for(true).description).toBe("true"); + expect(Symbol.for({}).description).toBe("[object Object]"); + expect(Symbol.for().description).toBe("undefined"); + expect(Symbol.for(null).description).toBe("null"); +}); -// test("symbol argument throws an error", () => { -// expect(() => { -// Symbol.for(Symbol()); -// }).toThrowWithMessage(TypeError, "Cannot convert symbol to string"); -// }); +test("symbol argument throws an error", () => { + expect(() => { + Symbol.for(Symbol()); + }).toThrowWithMessage(TypeError, "Cannot convert symbol to string"); +}); diff --git a/Libraries/LibJS/Tests/builtins/Symbol/Symbol.keyFor.js b/Libraries/LibJS/Tests/builtins/Symbol/Symbol.keyFor.js index 7c70f00d98..8b04f652bc 100644 --- a/Libraries/LibJS/Tests/builtins/Symbol/Symbol.keyFor.js +++ b/Libraries/LibJS/Tests/builtins/Symbol/Symbol.keyFor.js @@ -1,24 +1,24 @@ -// test("basic functionality", () => { -// const localSym = Symbol("bar"); -// const globalSym = Symbol.for("bar"); +test("basic functionality", () => { + const localSym = Symbol("foo"); + const globalSym = Symbol.for("foo"); -// expect(Symbol.keyFor(localSym)).toBeUndefined(); -// expect(Symbol.keyFor(globalSym)).toBe("bar"); -// }); + expect(Symbol.keyFor(localSym)).toBeUndefined(); + expect(Symbol.keyFor(globalSym)).toBe("foo"); +}); -// test("bad argument values", () => { -// [ -// [1, "1"], -// [null, "null"], -// [undefined, "undefined"], -// [[], "[object Array]"], -// [{}, "[object Object]"], -// [true, "true"], -// ["foobar", "foobar"], -// [function () {}, "[object ScriptFunction]"], // FIXME: Better function stringification -// ].forEach(testCase => { -// expect(() => { -// Symbol.keyFor(testCase[0]); -// }).toThrowWithMessage(TypeError, `${testCase[1]} is not a symbol`); -// }); -// }); +test("bad argument values", () => { + [ + [1, "1"], + [null, "null"], + [undefined, "undefined"], + [[], "[object Array]"], + [{}, "[object Object]"], + [true, "true"], + ["foobar", "foobar"], + [function () {}, "[object ScriptFunction]"], // FIXME: Better function stringification + ].forEach(testCase => { + expect(() => { + Symbol.keyFor(testCase[0]); + }).toThrowWithMessage(TypeError, `${testCase[1]} is not a symbol`); + }); +});