RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 19:45:08 +00:00
Code Issues Activity Actions

LibHTML: Have element keep a pointer to their resolved style

Browse source 
This will make it easy to implement a simple element style inspector.
This commit is contained in:
Andreas Kling 2020-01-02 14:52:34 +01:00
parent 285130cc55
commit ffcd395afc
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibHTML/DOM/Element.cpp
View file

@ -78,6 +78,7 @@ bool Element::has_class(const StringView& class_name) const
RefPtr<LayoutNode> Element::create_layout_node(const StyleProperties* parent_style) const RefPtr<LayoutNode> Element::create_layout_node(const StyleProperties* parent_style) const
{ {
auto style = document().style_resolver().resolve_style(*this, parent_style); auto style = document().style_resolver().resolve_style(*this, parent_style);
const_cast<Element&>(*this).m_resolved_style = style;
auto display = style->string_or_fallback(CSS::PropertyID::Display, "inline"); auto display = style->string_or_fallback(CSS::PropertyID::Display, "inline");
if (display == "none") if (display == "none")
@ -139,6 +140,7 @@ void Element::recompute_style()
return; return;
ASSERT(parent_layout_node); ASSERT(parent_layout_node);
auto style = document().style_resolver().resolve_style(*this, &parent_layout_node->style()); auto style = document().style_resolver().resolve_style(*this, &parent_layout_node->style());
m_resolved_style = style;
if (!layout_node()) { if (!layout_node()) {
if (style->string_or_fallback(CSS::PropertyID::Display, "inline") == "none") if (style->string_or_fallback(CSS::PropertyID::Display, "inline") == "none")
return; return;

4
Libraries/LibHTML/DOM/Element.h
View file

@ -56,6 +56,8 @@ public:
String name() const { return attribute("name"); } String name() const { return attribute("name"); }
const StyleProperties* resolved_style() const { return m_resolved_style.ptr(); }
private: private:
RefPtr<LayoutNode> create_layout_node(const StyleProperties* parent_style) const override; RefPtr<LayoutNode> create_layout_node(const StyleProperties* parent_style) const override;
@ -64,6 +66,8 @@ private:
String m_tag_name; String m_tag_name;
Vector<Attribute> m_attributes; Vector<Attribute> m_attributes;
RefPtr<StyleProperties> m_resolved_style;
}; };
template<> template<>