RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:27:35 +00:00
Code Issues Activity Actions

LibWeb: Make layout tree have non-const pointers to the DOM

Browse source 
Const pointers into the DOM was a nice idea, but in practice, there are
too many situations where the layout tree wants to some non-const thing
to the DOM.
This commit is contained in:
Andreas Kling 2020-07-28 19:48:57 +02:00
parent a4eadeb80d
commit fffc5896d8
33 changed files with 38 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/Layout/LayoutNode.h
View file

@ -53,7 +53,7 @@ public:
bool is_anonymous() const { return !m_node; }
const DOM::Node* node() const { return m_node; }
DOM::Node* node() { return const_cast<DOM::Node*>(m_node); }
DOM::Node* node() { return m_node; }
DOM::Document& document() { return m_document; }
const DOM::Document& document() const { return m_document; }
@ -195,13 +195,13 @@ public:
float font_size() const;
protected:
LayoutNode(DOM::Document&, const DOM::Node*);
LayoutNode(DOM::Document&, DOM::Node*);
private:
friend class LayoutNodeWithStyle;
DOM::Document& m_document;
const DOM::Node* m_node { nullptr };
DOM::Node* m_node { nullptr };
bool m_inline { false };
bool m_has_style { false };
@ -221,7 +221,7 @@ public:
void apply_style(const CSS::StyleProperties&);
protected:
LayoutNodeWithStyle(DOM::Document&, const DOM::Node*, NonnullRefPtr<CSS::StyleProperties>);
LayoutNodeWithStyle(DOM::Document&, DOM::Node*, NonnullRefPtr<CSS::StyleProperties>);
private:
LayoutStyle m_style;
@ -237,7 +237,7 @@ public:
const BoxModelMetrics& box_model() const { return m_box_model; }
protected:
LayoutNodeWithStyleAndBoxModelMetrics(DOM::Document& document, const DOM::Node* node, NonnullRefPtr<CSS::StyleProperties> style)
LayoutNodeWithStyleAndBoxModelMetrics(DOM::Document& document, DOM::Node* node, NonnullRefPtr<CSS::StyleProperties> style)
: LayoutNodeWithStyle(document, node, move(style))
{
}