RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:27:35 +00:00
Code Issues Activity Actions
38353 commits 1 branch 0 tags 230 MiB
Commit graph

16464 commits

Author SHA1 Message Date
MacDue
739d870091 Fire: Ignore mouse events outside the window (to the left) 
This fixes a small issue where if you drag the cursor outside the
window on the left-hand side, the fire demo will still respond to
the mouse events, but wrapped around to the right of the window.
 2022-05-08 18:15:12 +02:00
MacDue
934ea4faf1 Fire: Replace #defines with constexprs 2022-05-08 18:15:12 +02:00
Torstennator
f9ec3b986e LibGUI: Fix {Value,Opacity}Slider value changes for values less than 0 
This patch fixes a value glitch when changing the slider value via
dragging the knob with the mouse and having a min value smaller than 0.
Before this patch it was not possible to drag the value below 0 and it
just snapped to the configured min value if the mouse was at the most
left position. Now the value is calculated from the value range and
mouse position within the widget.
 2022-05-08 17:17:56 +02:00
Luke Wilde
ee6fb51db6 LibJS: Add a couple of missing spec steps to PerformEval 
I missed these in 34f902fb52.
 2022-05-08 17:12:27 +02:00
Luke Wilde
77ba3d3e3f LibJS: Remove callerRealm from HostEnsureCanCompileStrings 
This is a normative change in the ecma262 spec.

See: 2527be4
 2022-05-08 17:12:27 +02:00
Vitaly Dyachkov
a0a4d169f4 AK+LibGUI: Pass predicate to *_matching() methods by const reference 2022-05-08 17:02:00 +02:00
Romain Chardiny
6ed2ded77c KeyboardSettings: Also activate keymap via ListView's on_activation 2022-05-08 16:58:20 +02:00
Karol Kosek
92f4408d66 DisplaySettings: Make the copy action copy the background path as url 
Closes: #13907
 2022-05-08 16:41:04 +02:00
EWouters
053fc51b7d Mandelbrot: Remove image export confirmation dialog 
Andreas mentioned this dialog is not needed in the monthly update
video[^1].

[^1]: https://youtu.be/yUmHEYs5n34?t=364
 2022-05-08 16:38:19 +02:00
faxe1008
86d5e5a90c LibGUI: Add button to PasswordBox to reveal the password 
This patch adds an eye-like button to the PasswordBox
which allows the user to reveal the typed password.
Whether or not the button is shown is controllable via
an additional property within the PasswordBox.
 2022-05-08 16:36:53 +02:00
faxe1008
448d6b9acc LibGUI: Make TextEditor substitution more explicit 
This patch changes the member for the code point substitution to be an
Optional to remove the implicitness of the zero value.
 2022-05-08 16:36:53 +02:00
offtkp
70e2b42b9d WindowServer: Consider screen scaling when getting color under cursor 
Multiply the cursor position by the current scaling mode multiplier when
getting the color under the cursor. Also multiply the screen rectangle
before checking if the cursor is within bounds.

Color picker would not account for scaling when getting the color under
the cursor.

Fixes #13906.
 2022-05-08 16:36:24 +02:00
Ali Mohammad Pur
1830996ac9 xml: Avoid UAF in Error return from serenity_main() 
ErrorOr<int> cannot own a string, and the string is scrubbed when freed,
so we'd get garbage when errors were printed.
 2022-05-08 16:34:58 +02:00
stelar7
cd73d5c1d0 LibWeb: Add missing preprocessing step to the css tokenizer 2022-05-08 16:29:46 +02:00
stelar7
4359d4eb5d LibWeb: Note and fix Gfx related quirk in ColorStyleValue::to_string 2022-05-08 16:29:18 +02:00
stelar7
fa05c99b22 LibWeb: Commit transaction after parsing '+'?† n <signed-integer> 2022-05-08 16:29:06 +02:00
stelar7
469380d6bc LibWeb: Dont consider '-n-' a dashndashdigit-ident token 2022-05-08 16:29:06 +02:00
stelar7
2b3c07f4ad LibWeb: Include sign in token debug info, if the type has explicit sign 2022-05-08 16:29:06 +02:00
stelar7
5ca8e2a751 LibWeb: Dont try to fetch another token in an+b parsing 
When parsing <ndash-dimension> <signless-integer>, we tried to parse
a new token from the stream instead of using the value we had already
extracted. This caused pages that used the syntax to crash.
 2022-05-08 16:29:06 +02:00
stelar7
303b72d516 LibWeb: Make an+b pattern selector serialization spec compliant 2022-05-08 16:29:06 +02:00
Linus Groh
b751f80166 LibJS: Change internal slots of Duration to store mathematical values 
This is a normative change in the Temporal spec.

See: 1f3fba8
 2022-05-08 01:01:32 +02:00
Linus Groh
cc8f5151d7 LibJS: Refactor Temporal since/until to common AOs 
This is an editorial change in the Temporal spec.

See: 85a9f57
 2022-05-08 00:07:58 +02:00
Linus Groh
fc6cf3cb9d LibJS: Remove ToISODayOfWeek 
This is an editorial change in the Temporal spec.

See: 3eab7e4
 2022-05-08 00:07:58 +02:00
Linus Groh
cabcdd838b LibJS: Remove ToISODayOfYear 
This is an editorial change in the Temporal spec.

See: 6117d90
 2022-05-08 00:07:58 +02:00
Linus Groh
a216c0b6df LibJS: Remove IsISOLeapYear 
This is an editorial change in the Temporal spec.

See: a36bdd4
 2022-05-08 00:07:58 +02:00
Linus Groh
6d0d7c8fd0 LibJS: Remove ISODaysInYear 
This is an editorial change in the Temporal spec.

See: f62e737
 2022-05-08 00:07:58 +02:00
Linus Groh
ade7946217 LibJS: Simplify DifferenceISODate 
This is an editorial change in the Temporal spec.

See: 76452d2
 2022-05-08 00:07:58 +02:00
Linus Groh
6a2b73a4a9 LibJS: Simplify DaysUntil 
This is an editorial change in the Temporal spec.

See: b2254b4
 2022-05-08 00:07:58 +02:00
Linus Groh
de0ea331cd LibJS: Simplify BalanceISODate 
This is an editorial change in the Temporal spec.

See: 9544573
 2022-05-08 00:07:58 +02:00
Linus Groh
938e68d003 LibJS: Remove type assertion comment from IsValidISODate 
This is an editorial change in the Temporal spec.

See: ddb5652
 2022-05-08 00:07:58 +02:00
Linus Groh
15fe6297bc LibJS: Use "Completion" to emphasize completion record 
This is an editorial change in the Temporal spec.

See: 31d9fc5
 2022-05-08 00:07:58 +02:00
Linus Groh
f64b69955e LibJS: Fix numeric type in Date.prototype.toTemporalInstant() 
This is an editorial change in the Temporal spec.

See: 435a111
 2022-05-08 00:07:58 +02:00
Linus Groh
c6f7214a60 LibJS: Replace magic nanosecond numbers with constants 
This is an editorial change in the Temporal spec.

See: 3fdbfda
 2022-05-08 00:07:58 +02:00
Linus Groh
3729a910f6 LibJS: Refactor Temporal add/subtract to common AOs 
This is an editorial change in the Temporal spec.

See:
- 2f96efc
- fbff635
 2022-05-08 00:07:58 +02:00
MacDue
875093e6a9 DisplaySettings: Fix Clang build failure in ThemePreviewWidget 2022-05-07 23:46:41 +02:00
Linus Groh
360e149c5c ThemeEditor: Fix Clang build failure in PreviewWidget 2022-05-07 23:33:00 +02:00
MacDue
cf5b6c5c8d Demos/Eyes: Render eyes antialiased 
This looks good, and is a good way to test ellipse rendering is
working properly.
 2022-05-07 22:59:02 +02:00
MacDue
89445b967d PixelPaint: Add antialiased ellipse option 
Currently this option is only supported for filled ellipses as that
is all the AntiAliasingPainter supports.
 2022-05-07 22:59:02 +02:00
MacDue
60aba4c9f3 LibGfx: Implement AntiAliasingPainter::draw_ellipse() 
This commit adds draw_ellipse() and moves the shared code
for circles and ellipses to draw_ellipse_part().

draw_ellipse_part() can draw an entire circle in one call using
8-way symmetry and an ellipse in two calls using 4-way symmetry.
 2022-05-07 22:59:02 +02:00
MacDue
6e52e6b554 DisplaySettings: Center preview with center_window_group_within() 2022-05-07 22:58:55 +02:00
MacDue
e924aa338c ThemeEditor: Center preview with center_window_group_within() 2022-05-07 22:58:55 +02:00
MacDue
21c647dd75 LibGUI: Add center_window_group_within() to AbstractThemePreview 
This method will center a group of window rects, within some
bounds, accounting for the properties of the currently selected theme
(i.e. border width, title height, etc).
 2022-05-07 22:58:55 +02:00
offtkp
d24ec130bf FileManager: Don't show new dotfiles if the option is disabled 2022-05-07 20:31:40 +02:00
Hendiadyoin1
6c41267dcf UserspaceEmulator: Delegate rounding to the actual hardware 
This also makes us a bit more accurate, due to better rounding of
intermediate results.

This also gives us the flush-to-zero and denormals-are-zero SSE settings
for free! (Assuming UE is build with SSE)
 2022-05-07 20:27:05 +02:00
Hendiadyoin1
56a31ab376 LibM: Delegate rounding to fully to the FRNDINT instruction 
This is only enabled for clang right now, because it does not seem to
work on GCC.

Also fixes the types of two intermediate results

Co-authored-by: kleines Filmröllchen <filmroellchen@serenityos.org>
 2022-05-07 20:27:05 +02:00
Hendiadyoin1
9aa4958234 LibGfx: Use round_to<int> in Painter::draw_text_line 2022-05-07 20:25:39 +02:00
Hendiadyoin1
d866637074 LibSoftGPU: Use round_to<int> in Device::get_rasterization_rect_of_size 2022-05-07 20:25:39 +02:00
Hendiadyoin1
db0ba9f647 LibGfx: Use some AK/Math helpers in AffineTransform 
This makes us use AK::sincos and AK::hypot
 2022-05-07 20:25:39 +02:00
Hendiadyoin1
5fd49b9d9f LibGfx: Avoid some unnecessary Rounding in AffineTransform and Color 
Casts suffice in these cases.
(Assuming standard rounding mode)
 2022-05-07 20:25:39 +02:00
Hendiadyoin1
65f57efb5b LibGfx: Specialize Rect::to_rounded a bit more 
We were always calling llround[fd], even for floating point targets.
Also for rounding to integer, we don't need to have C99's rounding rules
and can just cast, assuming the standard rounding mode.
 2022-05-07 20:25:39 +02:00