FrHun
c79e3e5a8b
Applications: Make settings outer margins and spacing consistent
2022-07-15 12:34:25 +02:00
sin-ack
3f3f45580a
Everywhere: Add sv suffix to strings relying on StringView(char const*)
...
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).
No functional changes.
2022-07-12 23:11:35 +02:00
Maciej
e1722d39df
BrowserSettings: Make content filtering on by default
...
It was default in Browser but not default in settings, so the checkbox
was initially not checked.
2022-07-03 13:19:52 +02:00
Maciej
503e4b805f
BrowserSettings: Make default content filtering flag constexpr
...
And add s_ prefix per coding style guidelines.
2022-07-03 13:19:52 +02:00
Andrew Kaster
9d70f0383f
Browser: Remove GML formatting errors from BrowserSettingsWidget.gml
...
Regressed in commit 6571455499
2022-06-27 08:23:13 +01:00
Xexxa
b691269912
Base+Browser+BrowserSettings: Add default page for new tab
2022-06-26 22:18:30 +01:00
Xexxa
6571455499
Browser+BrowserSettings: Add preference for new tab
2022-06-26 22:18:30 +01:00
ferhatgec
e9e1959d4c
BrowserSettings: Avoid adding empty domain to content filter
2022-06-17 19:45:52 +01:00
Sam Atkins
cdffe556c8
LibGUI+Userland: Make Dialog::ExecResult an enum class
2022-05-13 16:27:43 +02:00
Sam Atkins
f27985a021
BrowserSettings: Set window modified state
2022-05-12 13:10:49 +02:00
IT6uru
00a0b1bd14
BrowserSettings: Add missing code to update filtering checkbox
...
reset_default_values() now sets default filtering checkbox
state using default_enable_content_filtering.
2022-05-06 11:37:38 +02:00
Sam Atkins
5702f016f0
LibGUI+Applications: Add --open-tab option to FooSettings applications
...
Similar to SystemMonitor's option of the same name, this allows you to
launch the given application with the specific tab open.
2022-04-21 17:24:42 +02:00
Sam Atkins
ded5ba1f87
LibGUI+Applications: Give SettingsWindow tabs a string ID
...
This gives us a convenient way to refer to them, which will be used in
the following commit.
2022-04-21 17:24:42 +02:00
Sam Atkins
d564cf1e89
LibCore+Everywhere: Make Core::Stream read_line() return StringView
...
Similar reasoning to making Core::Stream::read() return Bytes, except
that every user of read_line() creates a StringView from the result, so
let's just return one right away.
2022-04-16 13:27:51 -04:00
Julen Ruiz Aizpuru
23ea5c6721
BrowserSettings: Validate homepage URL
2022-04-11 08:19:29 -04:00
Andreas Kling
c001e3f2fd
BrowserSettings: Run gml-format on ContentFilterSettingsWidget.gml
2022-02-18 19:21:12 +01:00
Maciej
1606f70f0c
BrowserSettings: Implement GUI for setting up content filters :^)
2022-02-18 19:00:42 +01:00
Lenny Maiorani
160bda7228
Applications: Use default constructors/destructors
...
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules
"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
2022-02-14 22:06:55 +00:00
Idan Horowitz
c8ab45e79f
Userland: Run gml-format
...
This brings the existing GML files up to spec with the new requirements
2022-02-13 02:36:35 +02:00
Vitaly Dyachkov
32b8795091
LibConfig: Rename pledge_domains(String) => pledge_domain(String)
...
pledge_domains() that takes only one String argument was specifically
added as a shortcut for pledging a single domain. So, it makes sense to
use singular here.
2022-02-11 18:06:39 +01:00
kleines Filmröllchen
6ee597369d
Meta+Userland: Run the GML formatter on CI and pre-commit
...
Now that the GML formatter is both perserving comments and also mostly
agrees to the existing GML style, it can be used to auto-format all the
GML files in the system. This commit does not only contain the scripts
for running the formatting on CI and the pre-commit hook, but also
initially formats all the existing GML files so that the hook is
successfull.
2022-02-07 18:39:50 +01:00
Dylan Katz
ca912a87f1
BrowserSettings: Set icons from GML
2022-01-29 13:45:34 +01:00
Timothy Flynn
da2eb63652
BrowserSettings: Use standard text placement for check box text
2022-01-28 13:20:19 +01:00
Sam Atkins
3ca2aee054
Applications: Cast unused smart-pointer TRY return values to void
2021-12-05 15:31:03 +01:00
Andreas Kling
60c132d7d3
LibGUI: Move GUI::SettingsWindow setup out of the constructor
...
In order to propagate errors that occur during UI setup, we have to move
all that logic out of widget/window subclass constructors. This is a
first attempt at doing that, for GUI::SettingsWindow.
2021-11-28 08:54:22 +01:00
Andreas Kling
45844f9338
LibGUI: Make GUI::SettingsWindow::add_tab() return ErrorOr
...
This allows us to use TRY() when creating settings UI.
2021-11-28 08:10:53 +01:00
Brian Gianforcaro
cf4fa936be
Everywhere: Use default execpromises argument for Core::System::pledge
2021-11-28 08:04:57 +01:00
Sam Atkins
a1e1405f26
BrowserSettings: Add some icons for it :^)
2021-11-26 22:14:56 +01:00
Sam Atkins
e84b3e7110
BrowserSettings: Implement restoring default values
2021-11-26 22:14:56 +01:00
Sam Atkins
f2b8ae7d86
BrowserSettings: Add preferred-color-scheme setting
2021-11-26 22:14:56 +01:00
Sam Atkins
11466c5316
BrowserSettings: Add setting for search engine
2021-11-26 22:14:56 +01:00
Sam Atkins
1933076143
Browser+BrowserSettings: Persist the "show bookmarks bar" setting
...
Previously this setting was only temporary, but we now save/load it from
the config file.
2021-11-26 22:14:56 +01:00
Sam Atkins
8a284be5c7
BrowserSettings: Create a BrowserSettings application :^)
...
Browser has a bunch of settings, but most are non-trivial to add here.
So far, these are implemented:
- Homepage URL
- Whether to close download windows when they complete
The others will be added in subsequent commits.
2021-11-26 22:14:56 +01:00
